On 9 June 2006 at 18:06, geirm@apache.org wrote:
> Author: geirm
> Date: Fri Jun 9 11:06:17 2006
> New Revision: 413113
>
> URL: http://svn.apache.org/viewvc?rev=413113&view=rev
> Log:
> tweaks to stop the <apr-1/foo.h> stuff, and
> just do <foo.h> for APR includes. Not a big deal
> but let me get more comfortable w/ the build.
>
> No functional changes.
>
> Code change commit will follow
[ snipped, good stuff cleaning up includes. ]
There are issues like this with the awt/swing contribution (see
HARMONY-534) doing includes in non-standard and even in a way that broke
the build for me. I think it is a big deal to use header files in the
way that is intended/common.
...
> Modified: incubator/harmony/enhanced/drlvm/trunk/build/make/targets/common_cl
> asslib.xml
> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/buil
> d/make/targets/common_classlib.xml?rev=413113&r1=413112&r2=413113&view=diff
> =============================================================================
> =
> --- incubator/harmony/enhanced/drlvm/trunk/build/make/targets/common_classlib
> .xml (original)
> +++ incubator/harmony/enhanced/drlvm/trunk/build/make/targets/common_classlib
> .xml Fri Jun 9 11:06:17 2006
> @@ -75,6 +75,13 @@
> <compiler id="common.compiler">
> <!--common for cpp and c-->
> <includepath>
> +
> +<!-- $$$ geirm for what's coming...
> + <pathelement location="${build.CLASSLIB.home}/deploy/include
> " />
> + <pathelement location="${build.CLASSLIB.home}/deploy/jdk/inc
> lude" />
> + <pathelement location="${build.CLASSLIB.home}/modules/luni/s
> rc/main/native/include/shared" />
I don't think you should need this last one. Any header is intended to
define a public interface to the luni module should have been copied to
deploy/include by the build. If you need to point in to the module,
then we might have a discrepancy about what is public/private that needs
addressing.
-Mark.
> +-->
>
> <pathelement location="${os.native.dir}/include" />
> <pathelement location="${shared.dir}/include" />
> <pathelement location="${common.src}" />
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
|