Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 91074 invoked from network); 19 May 2006 11:32:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 May 2006 11:32:13 -0000 Received: (qmail 94097 invoked by uid 500); 19 May 2006 11:32:10 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 94054 invoked by uid 500); 19 May 2006 11:32:09 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 94043 invoked by uid 99); 19 May 2006 11:32:09 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2006 04:32:09 -0700 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=RCVD_IN_BL_SPAMCOP_NET,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of mloenko@gmail.com designates 66.249.92.171 as permitted sender) Received: from [66.249.92.171] (HELO ug-out-1314.google.com) (66.249.92.171) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2006 04:32:08 -0700 Received: by ug-out-1314.google.com with SMTP id q2so711689uge for ; Fri, 19 May 2006 04:31:47 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=TVoNoueahulXawRxQarV5NEZiIo/2dflOSuKZ70LQgxdmVoGShjG0lwRCK2v9TOq7Nol94yO9BFg3bTKf5Fu90MFsE6QB/K6SoPvfmUskBEeCUF3QAjhL7DZXRr0Y2xA+/q9LiS2KUcaPyiUN92+6DGQqrk/3aWpjwRG0s6pSQc= Received: by 10.66.166.7 with SMTP id o7mr1344977uge; Fri, 19 May 2006 04:31:47 -0700 (PDT) Received: by 10.67.25.13 with HTTP; Fri, 19 May 2006 04:31:47 -0700 (PDT) Message-ID: <906dd82e0605190431i1a27f97fj7faee94916f12d06@mail.gmail.com> Date: Fri, 19 May 2006 18:31:47 +0700 From: "Mikhail Loenko" To: harmony-dev@incubator.apache.org Subject: Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java In-Reply-To: <6e47b64f0605190325rb907e45j4df4cf200b914cf3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <6e47b64f0605190214w5636ebc6kf3fd84a6fc606ac7@mail.gmail.com> <446D9497.2060205@googlemail.com> <6e47b64f0605190322x649e4629i24aabc17907cff73@mail.gmail.com> <6e47b64f0605190325rb907e45j4df4cf200b914cf3@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Stepan how far the prototype from what is desired? Thanks, Mikhail 2006/5/19, Stepan Mishura : > On 5/19/06, Stepan Mishura wrote: > > > Hi George, > > > > see below > > > > On 5/19/06, George Harley wrote: > > > > > Hi Stepan, > > > > > > Yes, there is probably scope for adding some logic to this test metho= d > > > where - in the event of no network connection we write a message to > > > stderr and move on. An alternative is to provide for connections to b= e > > > opened up against a server on the local machine. A couple of days ago= I > > > spent some time adding the small, lightweight (and Apache licensed) > > > Jetty server to the LUNI tests. In my local sandbox the LUNI > > > make/build.xml file the run.tests target was updated to start up Jett= y > > > --> run the LUNI tests --> stop Jetty. It worked fine apart from a > > > glitch I had getting the cgi-bin to work properly in Jetty. Apparentl= y > > > this is a fairly common problem when it is used on Windows. I'm start= ing > > > to feel that it might be best to exclude the one or two cgi-bin relat= ed > > > tests in the LUNI tests for now in the interests of bringing Jetty on > > > board. It would certainly help get some more java.net tests up and > > > running and enable this particular test case to run without the need = for > > > a network connection. What do you think ? > > > > > > I think that we should try to develop small local test server that jus= t > > opens connection and optionally send/receive test message. There is a > > prototype of such test server (see HARMONY-167) and but I didn't integr= ate > > it with tests yet. > > > > Sorry, wrong JIRA number - see HARMONY-164 > > Thanks, > Stepan. > > > > > > > > > > I would, of course, float the Jetty proposal on the dev list first to > > > make sure we were all happy with the suggestion :-) > > > > > > I'm OK only if we separate tests with Jetty from common test suite run= . > > > > Thanks, > > Stepan. > > > > > > > > > Best regards, > > > George > > > > > > > > > > > > Stepan Mishura wrote: > > > > Richard, George > > > > > > > > I'm not fan of tests that depend on network connection. Is it > > > > necessary for > > > > this test: > > > > > > > > + public void test_getOutputStream_afterConnection() throws Excepti= on > > > { > > > > + URLConnection uc =3D new > > > > URL("http://www.apache.org ").openConnection > > ").openconnection/> > > > > > > > > (); > > > > + uc.setDoOutput(true); > > > > + uc.connect(); > > > > + assertNotNull( uc.getOutputStream()); > > > > + } > > > > > > > > Thanks, > > > > Stepan Mishura > > > > ------------------------------------------------------ > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.or= g > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.= org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.or= g > > > > > > > > > > > > -- > > Thanks, > > Stepan Mishura > > Intel Middleware Products Division > > > > ------------------------------------------------------ > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > -- > Thanks, > Stepan Mishura > Intel Middleware Products Division > > ------------------------------------------------------ > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org