Return-Path: 
 <harmony-dev-return-7647-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org
Received: (qmail 40620 invoked from network); 19 May 2006 14:03:33 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 19 May 2006 14:03:33 -0000
Received: (qmail 78540 invoked by uid 500); 19 May 2006 14:03:29 -0000
Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org
Received: (qmail 78495 invoked by uid 500); 19 May 2006 14:03:29 -0000
Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:harmony-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:harmony-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:harmony-dev@incubator.apache.org>
List-Id: <harmony-dev.incubator.apache.org>
Reply-To: harmony-dev@incubator.apache.org
Delivered-To: mailing list harmony-dev@incubator.apache.org
Received: (qmail 78484 invoked by uid 99); 19 May 2006 14:03:29 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2006 07:03:29 -0700
X-ASF-Spam-Status: No, hits=1.4 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: 82.138.226.220 is neither permitted nor
 denied by domain of t.p.ellison@gmail.com)
Received: from [82.138.226.220] (HELO dublin.purplecloud.com) (82.138.226.220)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 May 2006 07:03:28 -0700
Received: (qmail 12985 invoked from network); 19 May 2006 15:03:18 +0100
Received: from 64-60-253-20.cust.telepacific.net (HELO ?64.60.253.20?)
 (64.60.253.20)
  by smtp-dublin.purplecloud.com with (DHE-RSA-AES256-SHA encrypted) SMTP;
 19 May 2006 15:03:18 +0100
Message-ID: <446DD015.1000902@gmail.com>
Date: Fri, 19 May 2006 15:03:01 +0100
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 1.5.0.2 (Windows/20060308)
MIME-Version: 1.0
To: harmony-dev@incubator.apache.org
Subject: Re: svn commit: r407780 - in
 /incubator/harmony/enhanced/classlib/trunk/modules/archive/src:
 main/java/java/util/jar/Attributes.java
 test/java/org/apache/harmony/archive/tests/java/util/jar/AttributesTest.java
References: <20060519121724.27AD51A9835@eris.apache.org>
In-Reply-To: <20060519121724.27AD51A9835@eris.apache.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

mloenko@apache.org wrote:
<snip>
>  	public void putAll(Map attrib) {
> +        if( attrib == null ) {
> +            throw new ClassCastException();
> +        }

Shouldn't this have a message?  I thought we agreed that we'd add useful
messages to exceptions.

Regards,
Tim

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org