Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 21201 invoked from network); 3 May 2006 19:55:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 May 2006 19:55:52 -0000 Received: (qmail 40381 invoked by uid 500); 3 May 2006 19:55:48 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 40335 invoked by uid 500); 3 May 2006 19:55:47 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 40324 invoked by uid 99); 3 May 2006 19:55:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2006 12:55:47 -0700 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 64.74.244.71 is neither permitted nor denied by domain of geir@pobox.com) Received: from [64.74.244.71] (HELO chi.mobile-health-diary.com) (64.74.244.71) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 May 2006 12:55:47 -0700 Received: (qmail 5640 invoked from network); 3 May 2006 19:55:23 -0000 Received: from ool-43560634.dyn.optonline.net (HELO ?192.168.2.7?) (geir@67.86.6.52) by b014.internal.mobile-health-diary.com with SMTP; 3 May 2006 19:55:23 -0000 Message-ID: <44590A02.3080703@pobox.com> Date: Wed, 03 May 2006 15:52:34 -0400 From: Geir Magnusson Jr Reply-To: geir@pobox.com User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: harmony-dev@incubator.apache.org Subject: Re: [classlib] metadata-fest References: <44589AB7.6030405@gmail.com> In-Reply-To: <44589AB7.6030405@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Tim Ellison wrote: > [ If you don't know/care about either OSGi manifests or Eclipse, then > don't worry, you can ignore this note -- just continue as you are. ] > > > I'm going through the module manifests and putting in some explicit > imports to satisfy the requirements of the tests within a module. > > Since this means that a module will now 'import' (depend upon) a package > only because a test case uses it, I'm marking such imports in the > manifest as 'optional' -- this means that the same manifest can be used > in development and in the JARs that we deploy at runtime (which don't > contain the test code). The alternative would have been to move test > code out into a separate module but I'm NOT going there! That makes sense. > > Similarly, where a module manifest exports a package only to satisfy > somebody else's test code, it is done with a mandatory attribute to show > why it is being imported. :/ What's the downside? It doesn't matter now, but in the future, should we consider having the manifests assembled as part of the build based on target? Talking out of my hat, it sounds like each breaks into two parts, a 'manifest base' and 'manifest test' or -ish... > > I'll also commit updates Eclipse metadata (.project and .classpath > files) for our modules, for those people who want to follow along. Common custom is to keep that kind of thing out of SVN but I realize that as Eclipse is such a bear to set up.... ;) geir --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org