From harmony-dev-return-7221-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org Fri May 05 13:37:44 2006 Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 38392 invoked from network); 5 May 2006 13:37:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 May 2006 13:37:41 -0000 Received: (qmail 9569 invoked by uid 500); 5 May 2006 13:37:37 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 9528 invoked by uid 500); 5 May 2006 13:37:36 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 9516 invoked by uid 99); 5 May 2006 13:37:36 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2006 06:37:36 -0700 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 195.212.29.137 is neither permitted nor denied by domain of mark.hindess@googlemail.com) Received: from [195.212.29.137] (HELO mtagate4.uk.ibm.com) (195.212.29.137) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2006 06:37:34 -0700 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate4.uk.ibm.com (8.13.6/8.13.6) with ESMTP id k45DbC53119564 for ; Fri, 5 May 2006 13:37:12 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k45Dc2mK067496 for ; Fri, 5 May 2006 14:38:02 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.12.11/8.13.3) with ESMTP id k45DbBST002690 for ; Fri, 5 May 2006 14:37:11 +0100 Received: from anaheim.local (sig-9-145-2-13.uk.ibm.com [9.145.2.13]) by d06av02.portsmouth.uk.ibm.com (8.12.11/8.12.11) with ESMTP id k45DbBYV002681 for ; Fri, 5 May 2006 14:37:11 +0100 Message-Id: <200605051337.k45DbBYV002681@d06av02.portsmouth.uk.ibm.com> X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-7) with nmh-1.1 From: Mark Hindess To: harmony-dev@incubator.apache.org Subject: Re: svn commit: r400008 - in /incubator/harmony/enhanced/classlib/trunk/modules/text/src: main/java/java/text/ test/java/org/apache/harmony/text/tests/java/text/ In-reply-to: Your message of "Fri, 05 May 2006 11:33:55 BST." <445B2A13.3090604@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 05 May 2006 14:37:11 +0100 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 5 May 2006 at 11:33, Tim Ellison wrote: > > mloenko@apache.org wrote: > > > > Modified: incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/j > ava/org/apache/harmony/text/tests/java/text/BidiTest.java > > URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trun > k/modules/text/src/test/java/org/apache/harmony/text/tests/java/text/BidiTest > .java?rev=400008&r1=400007&r2=400008&view=diff > > =========================================================================== > === > > --- incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/or > g/apache/harmony/text/tests/java/text/BidiTest.java (original) > > +++ incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/or > g/apache/harmony/text/tests/java/text/BidiTest.java Fri May 5 00:55:46 2006 > > @@ -15,10 +15,8 @@ > > > > package org.apache.harmony.text.tests.java.text; > > > > -import java.text.AttributedString; > > import java.text.Bidi; > > import java.util.Arrays; > > -import java.util.List; > > > > import junit.framework.TestCase; > > > > @@ -59,6 +57,13 @@ > > } catch (IllegalArgumentException e) { > > // expected > > } > > + > > + try { > > + bd = new Bidi(null); > > + fail("should throw IAE"); > > + } catch (IllegalArgumentException e) { > > + assertEquals("paragraph is null", e.getMessage()); > > This assertion is bogus, the API spec doesn't require this text, and > it will fail when we switch to Russian locale messages. I mentioned that this should be removed in my most recent JIRA comment for this issue. > > > > + } catch (ParseException e) { > > + assertEquals("java.text.ParseException", e.getClass().getName( > )); > > Huh? Oops! Didn't spot that one. Who wrote that rubbish? ;-) -Mark. --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org