harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: [website] harmony-dev agreements and recommendations
Date Thu, 25 May 2006 14:38:13 GMT
2006/5/25, Mikhail Fursov <mike.fursov@gmail.com>:
> Guys,
> What do you think about the following recomendations?
> These are only 'recomendations' and not must have rules, but if these
> recomendations will become 'official'  it will improve the quality of API in
> the long perspective.
>
> 1) Try avoid "magic number" nor "magic strings" in code ( the constant name
> by itself can be a good comment )
> 2) Try to make all objects used for synchronization 'final'  (we have a lot
> of non-final monitors in API, so we give a chance to bugs)

Could you please explain with details and an example?

> 3) Never call to Boolean of Integer contructors (performance issue, there
> are a lot of such calls in our API)

Again, an example would be useful.

> 4) Never do manual array copying (our crypto API does )

What do you mean by 'manual array copying'? How it should be done and why?

Thanks,
Mikhail

> 5) Check if it's possible to make method static or private (performance
> issue, will help to devirtualizer a lot)
>
>
>
> On 5/25/06, Geir Magnusson Jr <geir@pobox.com> wrote:
> >
> > Nice!  Well done!
> >
> >
> >
>
>
> --
> Mikhail Fursov
> Intel Middleware Products Division
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message