harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magnusson, Geir" <geir.magnus...@intel.com>
Subject RE: svn commit: r407780 - in /incubator/harmony/enhanced/classlib/trunk/modules/archive/src: main/java/java/util/jar/Attributes.java test/java/org/apache/harmony/archive/tests/java/util/jar/AttributesTest.java
Date Fri, 19 May 2006 14:01:41 GMT
And if we didn't, I think we just did :)

-- 
Geir Magnusson Jr
SSG/MPD
geir.magnusson@intel.com
+1 203 665 6437  

> -----Original Message-----
> From: Tim Ellison [mailto:t.p.ellison@gmail.com] 
> Sent: Friday, May 19, 2006 7:03 AM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r407780 - in 
> /incubator/harmony/enhanced/classlib/trunk/modules/archive/src
> : main/java/java/util/jar/Attributes.java 
> test/java/org/apache/harmony/archive/tests/java/util/jar/Attri
> butesTest.java
> 
> mloenko@apache.org wrote:
> <snip>
> >  	public void putAll(Map attrib) {
> > +        if( attrib == null ) {
> > +            throw new ClassCastException();
> > +        }
> 
> Shouldn't this have a message?  I thought we agreed that we'd 
> add useful
> messages to exceptions.
> 
> Regards,
> Tim
> 
> -- 
> 
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message