harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: svn commit: r409607 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/net/ main/java/java/util/ test/java/tests/api/java/net/ test/java/tests/api/java/util/
Date Fri, 26 May 2006 10:05:44 GMT
On 5/26/06, Dmitry M. Kononov wrote:
>
> Stepan,
>
> On 5/26/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > Sorry, I didn't catch - what for the second catch block was inserted:
>
> The second catch allows us to see the human-readable message of the
> JUnit output, if the other than the UnsupportedEncodingException
> exception occurs for some reason.


I'd prefer to see an error's message and stack trace.

Actually, you are right, since Harmony does not throw
> UnsupportedEncodingException at all the second catch may be removed.
> What do you think, should it be removed? If yes, I am Ok with this.


Yes, it should be removed because it doesn't make sense -
UnsupportedEncodingException is caught by the first catch block.

Thanks,
Stepan.

> +    public void test_decodeLjava_lang_String_Ljava_lang_String() {
> > +        try {
> > +            URLDecoder.decode("", "");
> > +            fail("UnsupportedEncodingException expected");
> > +        } catch (UnsupportedEncodingException e) {
> > +            // expected
> > +        } catch (Exception e) {
> > +            assertEquals(UnsupportedEncodingException.class, e.getClass
> ());
> > +        }
> > +    }
>
> Thanks.
> --
> Dmitry M. Kononov
> Intel Managed Runtime Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message