Return-Path: 
 <harmony-dev-return-6775-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org
Received: (qmail 46107 invoked from network); 20 Apr 2006 12:07:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 20 Apr 2006 12:07:21 -0000
Received: (qmail 81061 invoked by uid 500); 20 Apr 2006 12:06:50 -0000
Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org
Received: (qmail 80677 invoked by uid 500); 20 Apr 2006 12:06:49 -0000
Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:harmony-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:harmony-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:harmony-dev@incubator.apache.org>
List-Id: <harmony-dev.incubator.apache.org>
Reply-To: harmony-dev@incubator.apache.org
Delivered-To: mailing list harmony-dev@incubator.apache.org
Received: (qmail 80666 invoked by uid 99); 20 Apr 2006 12:06:49 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2006 05:06:49 -0700
X-ASF-Spam-Status: No, hits=1.3 required=10.0
	tests=RCVD_IN_BL_SPAMCOP_NET,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of mark.hindess@googlemail.com
 designates 64.233.166.181 as permitted sender)
Received: from [64.233.166.181] (HELO pproxy.gmail.com) (64.233.166.181)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2006 05:06:48 -0700
Received: by pproxy.gmail.com with SMTP id i49so253186pyi
        for <harmony-dev@incubator.apache.org>;
 Thu, 20 Apr 2006 05:06:28 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=googlemail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=XGTWdb0oOdGzqnd/AMFNXb7L4QAJx7zu/Px6RFGXBiPiZR9emPTXaIcn+P6Iwo7t3bWEycqC2naDE+zHg5nZr9EFv4XSX+f7sABgU9bPqu7X3kSzy1OSST2sUFAL41eZo0Lg7LLmk+nbrP8QSrD4TxMAU6X0QYLSdz5yS6e2LVE=
Received: by 10.35.96.11 with SMTP id y11mr388113pyl;
        Thu, 20 Apr 2006 05:06:27 -0700 (PDT)
Received: by 10.35.63.11 with HTTP; Thu, 20 Apr 2006 05:06:27 -0700 (PDT)
Message-ID: <fcb9f9160604200506s4c61b67bxa31e868e08af7e3a@mail.gmail.com>
Date: Thu, 20 Apr 2006 13:06:27 +0100
From: "Mark Hindess" <mark.hindess@googlemail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: svn commit: r395541 -
 /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
In-Reply-To: <6e47b64f0604200423i330a57a9u2bb5a4e787083922@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20060420090531.46442.qmail@minotaur.apache.org>
	 <fcb9f9160604200230l7ce8657bic89be26249655a18@mail.gmail.com>
	 <6e47b64f0604200423i330a57a9u2bb5a4e787083922@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Without the classpath modifications then it works for me on linux.
-Mark.


On 4/20/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> On 4/20/06, Mark Hindess wrote:
> >
> > Stepan,
> >
> > In your original commit for HARMONY-315, you made this change:
> >
> >            <classpath>
> >                <pathelement path=3D"${hy.crypto.src.test.resources}"/>
> >            </classpath>
> >
> > I'm not sure how this relates to this JIRA
>
>
> Right, it was better to separate updates.
>
>  but it is this that breaks
> > the test.  Why not remove/fix this unrelated change rather than
> > comment out the otherwise working test?
>
>
> It is not quite correct. The tests passes on Windows but fails on Linux -
> I'm going to investigate the difference. But if I remove these lines then=
 it
> will fail on Windows too.
>
> IMHO, we should avoid making unrelated changes in a single commit.
>
>
> Agreed.
>
> Thanks,
> Stepan.
>
> Regards,
> > Mark.
> >
> > On 4/20/06, smishura@apache.org <smishura@apache.org> wrote:
> > > Author: smishura
> > > Date: Thu Apr 20 02:05:28 2006
> > > New Revision: 395541
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=3D395541&view=3Drev
> > > Log:
> > > tests/api/javax/crypto/CipherTest.java back to exclude test to make t=
est
> > suite pass on Linux
> > >
> > > Modified:
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/bu=
ild.xml
> > >
> > > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/bu=
ild.xml
> > > URL:
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk=
/modules/crypto/make/common/build.xml?rev=3D395541&r1=3D395540&r2=3D395541&=
view=3Ddiff
> > >
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > > ---
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/bu=
ild.xml
> > (original)
> > > +++
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/bu=
ild.xml
> > Thu Apr 20 02:05:28 2006
> > > @@ -118,6 +118,9 @@
> > >              <batchtest todir=3D"${hy.tests.reports}" haltonfailure=
=3D"no">
> > >                  <fileset dir=3D"${hy.crypto.src.test.java}">
> > >                      <include name=3D"**/*Test.java"/>
> > > +
> > > +                    <!-- Harmony exclude list -->
> > > +                    <exclude
> > name=3D"tests/api/javax/crypto/CipherTest.java"/>
> > >                  </fileset>
> > >              </batchtest>
> > >          </junit>
> > >
> > >
> > >
> >
> >
> > --
> > Mark Hindess <mark.hindess@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--
Mark Hindess <mark.hindess@googlemail.com>
IBM Java Technology Centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org