Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 29703 invoked from network); 18 Apr 2006 10:22:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Apr 2006 10:22:21 -0000 Received: (qmail 11127 invoked by uid 500); 18 Apr 2006 10:21:58 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 11071 invoked by uid 500); 18 Apr 2006 10:21:58 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 11053 invoked by uid 99); 18 Apr 2006 10:21:58 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 03:21:58 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of mark.hindess@googlemail.com designates 64.233.166.181 as permitted sender) Received: from [64.233.166.181] (HELO pproxy.gmail.com) (64.233.166.181) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 03:21:57 -0700 Received: by pproxy.gmail.com with SMTP id o67so1831180pye for ; Tue, 18 Apr 2006 03:21:36 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=googlemail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iSSn+8dcj2eM3TICh7wTOzShFslUjubVDaV2fkbukkr/LCIZuAo7fQ2SDiAvf4r1czZNAlwQzUrkUyKglgAuQ77w1zqrK70Q9Hd34yChsHaF7ljMor8vdSQfVZG/XncrMnHlNE97fv5kuwj7+NaV5h7lD+Efz4mwKiQkJj7LmJc= Received: by 10.35.70.17 with SMTP id x17mr915169pyk; Tue, 18 Apr 2006 03:21:36 -0700 (PDT) Received: by 10.35.63.11 with HTTP; Tue, 18 Apr 2006 03:21:36 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2006 11:21:36 +0100 From: "Mark Hindess" To: harmony-dev@incubator.apache.org Subject: Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo In-Reply-To: <6e47b64f0604180317v166cd620m972f8a6b1d344c3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <6e47b64f0604180317v166cd620m972f8a6b1d344c3@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N For many people however tabs are equivalent to 8 spaces so if what we really intend is 4 spaces then perhaps we should make them spaces not tabs? Otherwise we will be forever fixing identations because of editor differenc= es. -Mark. On 4/18/06, Stepan Mishura wrote: > On 4/18/06, Mark Hindess wrote: > > > > Stepan, > > > > Just curious what you are fixing here? Changing 8 spaces to tabs? > > Why does this matter? Shouldn't tabs (at the beginning of a line) > > always be equivalent to 8 spaces? > > > Mark, > > I'd prefer to have all build files follow one style - I don't like mixing > tabs and spaces even they looks the same. For this particular case - buil= d > files were initially created using tabs and I'd prefer to keep this style= . > Also for me tab is not equivalent to 8 spaces - Eclipse sets tab equivale= nt > to 4 spaces and I'm not going to change it because I like it :-) > > Thanks, > Stepan. > > Incidentally, I think 8 character indentations are excessive. Quite a > > few of the ant files use 4 character indentations which I find much > > easier to read. Ditto for java code. Perhaps we could agree which to > > use? > > > > Regards, > > -Mark - wondering if he might regret asking this > > > > On 4/18/06, smishura@apache.org wrote: > > > Author: smishura > > > Date: Tue Apr 18 02:38:29 2006 > > > New Revision: 394890 > > > > > > URL: http://svn.apache.org/viewcvs?rev=3D394890&view=3Drev > > > Log: > > > Correcting indentation > > > > > > Modified: > > > > > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/bu= ild.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/b= uild.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/buil= d.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build= .xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/bui= ld.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/bu= ild.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/buil= d.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/b= uild.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/buil= d.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/buil= d.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build= .xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/= build.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/bui= ld.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/bui= ld.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build= .xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/= build.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build= .xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/buil= d.xml > > > > > incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/bui= ld.xml > > > > > > Modified: > > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/bu= ild.xml > > > URL: > > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk= /modules/applet/make/common/build.xml?rev=3D394890&r1=3D394889&r2=3D394890&= view=3Ddiff > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- > > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/bu= ild.xml > > (original) > > > +++ > > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/bu= ild.xml > > Tue Apr 18 02:38:29 2006 > > > @@ -68,12 +68,12 @@ > > > > > > > > > > > > - > > > - > > > + > > > + > > > > > > > /> > > > > > > - > > + > > forkmode=3D"once" > > > printsummary=3D"withOutAndErr" > > > errorproperty=3D"test.errors" > > > > > > [ SNIP ] > > > > -- > > Mark Hindess > > IBM Java Technology Centre, UK. > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > -- > ----------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > Thanks, > Stepan Mishura > Intel Middleware Products Division > > -- Mark Hindess IBM Java Technology Centre, UK. --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org