Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of mloenko@gmail.com designates
 64.233.182.191 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=OQ8PejeI7CJ5hwHiFgxSdJH+QZgN9SsXxKXSqbwVS6YEm5zhrzdlcXTaDv4IochugZgQ42o7BOU8O8IIGVNlyGHEkISVA5mDuGOehfP17fqzpWg9/PTx02jhW7ZjEM83Uyly0RqrIehCiSzDVs0gujBRjSBl7B32dUn8iKKOSTg=
Message-ID: <906dd82e0604120642w39977b40n357ba430ef61971d@mail.gmail.com>
Date: Wed, 12 Apr 2006 20:42:58 +0700
From: "Mikhail Loenko" <mloenko@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: unstable NPE in the archive module
In-Reply-To: <906dd82e0604120622s7fc55712j743843e4cbca10e9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <906dd82e0604120622s7fc55712j743843e4cbca10e9@mail.gmail.com>

More of stack trace:

java.io.IOException: File is a Directory
=09at java.io.File.createNewFile(File.java:1035)
=09at java.io.File.createTempFile(File.java:1089)
=09at tests.support.resource.Support_Resources.createTempFolder(Support_Res=
ources.java:66)
=09at tests.support.resource.Support_Resources.getURL(Support_Resources.jav=
a:42)
=09at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.j=
ava:352)
=09at junit.framework.TestCase.runBare(TestCase.java:125)
=09at junit.framework.TestResult$1.protect(TestResult.java:106)
=09at junit.framework.TestResult.runProtected(TestResult.java:124)
=09at junit.framework.TestResult.run(TestResult.java:109)
=09at junit.framework.TestCase.run(TestCase.java:118)
=09at junit.framework.TestSuite.runTest(TestSuite.java:208)
=09at junit.framework.TestSuite.run(TestSuite.java:203)
=09at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUni=
tTestRunner.java:297)
=09at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(J=
UnitTestRunner.java:672)
=09at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUn=
itTestRunner.java:546)


So I see two bugs here. The first one in the implementation of java.io.File=
 -
according to the spec createNewFile should not throw exception if file
or directory exists.

The second bug is in Support_Resources - new file might appear between
the following lines:

=09folder =3D File.createTempFile("hyts_resources", "", null);
=09folder.delete();
=09folder.mkdirs();
So this should be in syncrhonized block

Can IO guys please comment?

Thanks,
Mikhail

2006/4/12, Mikhail Loenko <mloenko@gmail.com>:
> I'm seeing test errors in the archive module. I've heard that Stepan have=
 seen
> similar ones today in the morning.
>
> The errors are unstable: Stepan could not reproduce it and I did not see =
them
> previous time. So here they are:
>
> Class tests.api.java.util.jar.ManifestTest
>
> all tests error with:
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resourc=
es.java:73)
> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
>
>
> Class tests.api.java.util.jar.JarInputStreamTest
> 9 tests error with
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resourc=
es.java:73)
> at tests.support.resource.Support_Resources.getURL(Support_Resources.java=
:42)
> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.ja=
va:352)
>
> Ideas?
>
> Thanks,
> Mikhail
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org