From harmony-dev-return-6632-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org Mon Apr 17 06:06:48 2006 Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 66891 invoked from network); 17 Apr 2006 06:06:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Apr 2006 06:06:48 -0000 Received: (qmail 29464 invoked by uid 500); 17 Apr 2006 06:06:46 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 29413 invoked by uid 500); 17 Apr 2006 06:06:45 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 29402 invoked by uid 99); 17 Apr 2006 06:06:45 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Apr 2006 23:06:45 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of anton.avtamonov@gmail.com designates 64.233.162.192 as permitted sender) Received: from [64.233.162.192] (HELO nz-out-0102.google.com) (64.233.162.192) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Apr 2006 23:06:45 -0700 Received: by nz-out-0102.google.com with SMTP id m22so474236nzf for ; Sun, 16 Apr 2006 23:06:24 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VeqRJ/yJ3PK4UuCsos18LBqriuiMGHCBEb95jBJoRAIolYXCWdrMpg6DJVdJRlGcVxwjdgqC32lNDNEOuXHb1I3+Qfb6BzHt26gF+NVHxdE1I493wouvRFZCSLlmws+AhTUAw1ga0HoHvXhWOWxJhng6Gv6pjOW7ZfYLzPAV4jo= Received: by 10.64.204.12 with SMTP id b12mr1722359qbg; Sun, 16 Apr 2006 23:06:24 -0700 (PDT) Received: by 10.64.250.16 with HTTP; Sun, 16 Apr 2006 23:06:24 -0700 (PDT) Message-ID: <46d21a9a0604162306q73e0a474hca0d4a15bc8d66ed@mail.gmail.com> Date: Mon, 17 Apr 2006 10:06:24 +0400 From: "Anton Avtamonov" To: harmony-dev@incubator.apache.org Subject: Re: should strings in exceptions match the reference implementation? In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <011b01c660d5$2e802b50$1101a8c0@OFFICEDESKTOP> <906dd82e0604152206m4385f0fia6651ee40c58206a@mail.gmail.com> <5c8e69f0604161823r63392d44j32ae82981d2a95a@mail.gmail.com> <46d21a9a0604162235n69f1479dp39f88773592406a8@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 4/17/06, Mark Hindess wrote: > So, the second issue, should we be checking for messages/descriptions > in exception > tests, even to match what Harmony throws? If we do then our api tests > wont pass on other implementations. Hi Mark, As I said already I don't see any huge reasons to check the messages (probably for not being empty only). However I suppose sometimes it could be necessary. I'm pretty sure we will face many cases when we need to deviate from RI (it was discussed already in other threads). What I propose is to use for tests some utility method like isHarmony(). It will act as a 'formal' indicator of all our deviations. For this particular situation is should be something like: if (TestUtilities.isHarmony()) { assertEquals("some message", e.getMessage()) } What do you think? -- Anton Avtamonov, Intel Middleware Products Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org