harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess" <mark.hind...@googlemail.com>
Subject Re: [jira] Commented: (HARMONY-237) PropertyDescriptor constructors throws incorrect (or no) exception
Date Fri, 21 Apr 2006 07:51:08 GMT
Sorry,  My mistake.  All the test are there - just not where I was
expecting.  I was expecting them to be with the other error cases
earlier in the file.

Sorry,
 Mark.


On 4/21/06, Loenko, Mikhail Y <mikhail.y.loenko@intel.com> wrote:
> Mark,
>
> This is the test from the second patch, it is not quite clear which test
> from the first patch do you mean. Am I missing something?
>
> =============================================
>
> Author: mloenko
> Date: Thu Apr 20 23:23:20 2006
> New Revision: 395794
>
> URL: http://svn.apache.org/viewcvs?rev=395794&view=rev
> Log:
> fixes for HARMONY-237
> PropertyDescriptor constructors throws incorrect (or no) exception
>
> Modified:
>
> incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/ja
> va/beans/PropertyDescriptor.java
>
> incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/te
> sts/api/java/beans/PropertyDescriptorTest.java
>
> ...
>
> +        try {
> +            PropertyDescriptor pd = new
> PropertyDescriptor("",null,null);
> +            fail("Constructor PropertyDescriptor(\"\",null,null) should
> "+
> +                 "throw IntrospectionException");
> +        } catch (IntrospectionException e) {
> +            assertEquals("bad property name", e.getMessage());
> +        }
>
>
>
> Thanks,
> Mikhail
>
>
> >-----Original Message-----
> >From: Mark Hindess (JIRA) [mailto:jira@apache.org]
> >Sent: Friday, April 21, 2006 2:17 PM
> >To: harmony-commits@incubator.apache.org
> >Subject: [jira] Commented: (HARMONY-237) PropertyDescriptor
> constructors throws incorrect (or no)
> >exception
> >
> >    [
> http://issues.apache.org/jira/browse/HARMONY-237?page=comments#action_12
> 375504 ]
> >
> >Mark Hindess commented on HARMONY-237:
> >--------------------------------------
> >
> >This fixes the behaviour but it looks like the tests from the first
> patch for the three argument
> >case and from the second patch are still missing.
> >
> >
> >> PropertyDescriptor constructors throws incorrect (or no) exception
> >> ------------------------------------------------------------------
> >>
> >>          Key: HARMONY-237
> >>          URL: http://issues.apache.org/jira/browse/HARMONY-237
> >>      Project: Harmony
> >>         Type: Bug
> >
> >>   Components: Classlib
> >>     Reporter: Mark Hindess
> >>     Assignee: Mikhail Loenko
> >>     Priority: Minor
> >>  Attachments: 02.propertydescriptor.empty.propery.name.diff,
> propertydescriptor.npe.diff
> >>
> >> Passing all null arguments to these constructors gives incorrect
> behaviour.
> >> j.beans.PropertyDescriptor(j.l.String,j.l.Class):
> >>   RI throws j.beans.IntrospectionException but
> >>   Harmony throws j.l.NullPointerException
> >>
> j.beans.PropertyDescriptor(j.l.String,j.l.Class,j.l.String,j.l.String):
> >>   RI throws j.beans.IntrospectionException but
> >>   Harmony throws j.l.NullPointerException
> >>
> j.beans.PropertyDescriptor(j.l.String,j.l.reflect.Method,j.l.reflect.Met
> hod):
> >>   RI throws j.beans.IntrospectionException but
> >>   Harmony doesn't throw an exception
> >> Will attach a patch.
> >
> >--
> >This message is automatically generated by JIRA.
> >-
> >If you think it was sent incorrectly contact one of the administrators:
> >   http://issues.apache.org/jira/secure/Administrators.jspa
> >-
> >For more information on JIRA, see:
> >   http://www.atlassian.com/software/jira
>


--
Mark Hindess <mark.hindess@googlemail.com>
IBM Java Technology Centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message