harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess" <mark.hind...@googlemail.com>
Subject Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Date Thu, 20 Apr 2006 09:30:48 GMT
Stepan,

In your original commit for HARMONY-315, you made this change:

            <classpath>
                <pathelement path="${hy.crypto.src.test.resources}"/>
            </classpath>

I'm not sure how this relates to this JIRA but it is this that breaks
the test.  Why not remove/fix this unrelated change rather than
comment out the otherwise working test?

IMHO, we should avoid making unrelated changes in a single commit.

Regards,
 Mark.

On 4/20/06, smishura@apache.org <smishura@apache.org> wrote:
> Author: smishura
> Date: Thu Apr 20 02:05:28 2006
> New Revision: 395541
>
> URL: http://svn.apache.org/viewcvs?rev=395541&view=rev
> Log:
> tests/api/javax/crypto/CipherTest.java back to exclude test to make test suite pass on
Linux
>
> Modified:
>     incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>
> Modified: incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=395541&r1=395540&r2=395541&view=diff
> ==============================================================================
> --- incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml (original)
> +++ incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml Thu
Apr 20 02:05:28 2006
> @@ -118,6 +118,9 @@
>              <batchtest todir="${hy.tests.reports}" haltonfailure="no">
>                  <fileset dir="${hy.crypto.src.test.java}">
>                      <include name="**/*Test.java"/>
> +
> +                    <!-- Harmony exclude list -->
> +                    <exclude name="tests/api/javax/crypto/CipherTest.java"/>
>                  </fileset>
>              </batchtest>
>          </junit>
>
>
>


--
Mark Hindess <mark.hindess@googlemail.com>
IBM Java Technology Centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message