harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess" <mark.hind...@googlemail.com>
Subject Re: svn commit: r391236 - in /incubator/harmony/enhanced/classlib/trunk: make/build-test.xml modules/crypto/make/common/build.xml
Date Wed, 05 Apr 2006 05:21:06 GMT
Stepan,

Thanks, this fixed the problems I was seeing.

However, looking at your commit, I'd have preferred to import the
depends.xml and refer to junit as ../../${junit.dir} to reduce
coupling so we have fewer changes to make if/when we update the
dependencies.

Regards,
 Mark.


On 4/4/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> Mark, I've fixed it at repo revision 391277. Please let me know if you have
> any problems with it.
>
> Thanks,
> Stepan.
>
>
> On 4/4/06, Mark Hindess wrote:
> >
> > Since this change I am seeing test errors and failures.  Specifically
> > ClassNotFoundExceptions in all tests (I think, I checked a sample) in:
> >
> > javax.crypto
> > javax.crypto.interfaces
> > javax.crypto.serialization
> > javax.crypto.spec
> > org.apache.harmony.security.x.crypto
> >
> > -Mark.
> >
> > On 4/4/06, smishura@apache.org <smishura@apache.org> wrote:
> > > Author: smishura
> > > Date: Tue Apr  4 00:21:47 2006
> > > New Revision: 391236
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=391236&view=rev
> > > Log:
> > > Apply minor fix for HARMONY-279 (Extract crypto component from security
> > module). Adding crypto testsuite to common tests run
> > >
> > > Modified:
> > >     incubator/harmony/enhanced/classlib/trunk/make/build-test.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > >
> > > Modified: incubator/harmony/enhanced/classlib/trunk/make/build-test.xml
> > > URL:
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/make/build-test.xml?rev=391236&r1=391235&r2=391236&view=diff
> > >
> > ==============================================================================
> > > --- incubator/harmony/enhanced/classlib/trunk/make/build-test.xml(original)
> > > +++ incubator/harmony/enhanced/classlib/trunk/make/build-test.xml Tue
> > Apr  4 00:21:47 2006
> > > @@ -43,7 +43,7 @@
> > >
> > >         <!-- this list of components to test will grow to eventually be
> > all modules -->
> > >         <target name="test-all"
> > > -               depends="clean, test-luni, test-archive, test-text,
> > test-nio, test-xnet, test-nio_char, test-logging, test-jndi, test-sql,
> > test-prefs, test-beans, test-math, gen-report">
> > > +               depends="clean, test-luni, test-archive, test-text,
> > test-nio, test-xnet, test-nio_char, test-logging, test-jndi, test-sql,
> > test-prefs, test-beans, test-math, test-crypto, gen-report">
> > >         </target>
> > >
> > >         <target name="clean">
> > >
> > > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > URL:
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml?rev=391236&r1=391235&r2=391236&view=diff
> > >
> > ==============================================================================
> > > ---
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > (original)
> > > +++
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > Tue Apr  4 00:21:47 2006
> > > @@ -59,7 +59,8 @@
> > >                          <pathelement location="${hy.crypto
> > }/../security/test/common/unit"/>
> > >                      </src>
> > >
> > > -                    <include name="javax/crypto/**/*Test*.java" />
> > > +                    <include name="javax/crypto/**/*.java" />
> > > +                    <include
> > name="org/apache/harmony/security/x/crypto/*Test.java" />
> > >                      <include
> > name="org/apache/harmony/security/test/**/*" />
> > >                      <exclude name="**/SecurityTest.java"/>
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Mark Hindess <mark.hindess@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
>


--
Mark Hindess <mark.hindess@googlemail.com>
IBM Java Technology Centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message