harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: should strings in exceptions match the reference implementation?
Date Mon, 17 Apr 2006 08:09:35 GMT
2006/4/17, Andrew Zhang <zhanghuangzhu@gmail.com>:
> On 4/17/06, Anton Avtamonov <anton.avtamonov@gmail.com> wrote:
> >
> > Well, not completely agree. I RI has BUG, I agree to have
> > corresponding Harmony test failing. However do you think that
> > different exception messges say is a good reason to have failures? I
> > don't think so. Just a minor differemce which can be 'formally
> > documented' by using isHarmony() is tests.
>
>
> I agree with you that different exception messages are not failures. So in
> my opnion, we'd better avoid such test cases.
> If some exception messages are really very important to developers ( I don't
> have any idea about such Exception classes),

Hi Andrew

Look at tests/api/java/util/regex/PatternSyntaxExceptionTest to get some
ideas. When you parse something and that something is incorrect the
message does matter.

And you have a test to verify that you do not report ()s mismatch when
the problem is somewhere else.

Thanks,
Mikhail

> I think RI should contain similiar information so that we can write some
> test cases, which both RI and Harmony could pass, by verifying keywords
> instead.
> If "isHarmony()" is used, then what's the expected message? I don't think
> there's a "Harmony exception message spec" :-)
> People may argue which message is best or more meanfuling :)
>
> Wishes,
> > --
> > Anton Avtamonov,
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Andrew Zhang
> China Software Development Lab, IBM
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message