harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: [jira] Assigned: (HARMONY-353) improvements to junit test method usage
Date Tue, 25 Apr 2006 10:13:20 GMT
It would be nice to have a new combined patch.

Thanks,
Stepan.

On 4/25/06, Mark Hindess wrote:
>
>
> Stepan
>
> These patches have lots of clashes now.  I have new versions if you'd
> like me to upload them - or I can upload a new combined patch?
>
> -Mark.
>
> On 25 April 2006 at 9:56, "Stepan Mishura (JIRA)" <jira@apache.org> wrote:
> >      [ http://issues.apache.org/jira/browse/HARMONY-353?page=all ]
> >
> > Stepan Mishura reassigned HARMONY-353:
> > --------------------------------------
> >
> >     Assign To: Stepan Mishura
> >
> > > improvements to junit test method usage
> > > ---------------------------------------
> > >
> > >          Key: HARMONY-353
> > >          URL: http://issues.apache.org/jira/browse/HARMONY-353
> > >      Project: Harmony
> > >         Type: Improvement
> >
> > >   Components: Classlib
> > >     Reporter: Mark Hindess
> > >     Assignee: Stepan Mishura
> > >     Priority: Trivial
> > >  Attachments: 01.assertnull.diff, 02.assertequals.string.diff,
> 03.assertequ
> > als.constants.diff, 04.assertequals.char.constants.diff,
> 05.assertnotnull.dif
> > f, assert.usage.combined.diff, improved.assertequals.usage.diff
> > >
> > > While fixing the test in HARMONY-352, I found some confusing junit
> > > error messages.  They were things like:
> > >   error expected <actual> but got <expected>
> > > rather than:
> > >   error expected <expected> but got <actual>
> > > Because the arguments to the assertEquals method were the wrong way
> > > around.  The expected value should come first.  Anyway, I fixed these
> > > for that one test.  We should try to fix these when we find them and
> > > we should try to avoid adding any more.
> > > This JIRA is because I decided that it was reasonable to fix any
> method lik
> > e:
> > >   assertEquals(..., <constant>);
> > > since a constant couldn't very well be the value being tested.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators:
> >    http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> >    http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message