harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: svn commit: r395541 - /incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
Date Fri, 21 Apr 2006 05:47:52 GMT
Oh, I see - thanks!
- Stepan.

On 4/21/06, Mark Hindess wrote:
>
> But I can't see how.  It is a tirvial fix though changing cipherText
> on line 554 to 'ciphertext' to match the case of the checked in file
> name.
>
> -Mark.
>
>
> On 4/21/06, Mark Hindess <mark.hindess@googlemail.com> wrote:
> > It did when I submitted the patch.
> > -Mark.
> >
> > On 4/21/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > > Hi Mark,
> > >
> > > Do you mean that the test tests/api/javax/crypto/CipherTest.java
> passes on
> > > you linux without classpath modification?
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > On 4/20/06, Mark Hindess <mark.hindess@googlemail.com> wrote:
> > > >
> > > > Without the classpath modifications then it works for me on linux.
> > > > -Mark.
> > > >
> > > >
> > > > On 4/20/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > > > > On 4/20/06, Mark Hindess wrote:
> > > > > >
> > > > > > Stepan,
> > > > > >
> > > > > > In your original commit for HARMONY-315, you made this change:
> > > > > >
> > > > > >            <classpath>
> > > > > >                <pathelement path="${hy.crypto.src.test.resources
> }"/>
> > > > > >            </classpath>
> > > > > >
> > > > > > I'm not sure how this relates to this JIRA
> > > > >
> > > > >
> > > > > Right, it was better to separate updates.
> > > > >
> > > > >  but it is this that breaks
> > > > > > the test.  Why not remove/fix this unrelated change rather than
> > > > > > comment out the otherwise working test?
> > > > >
> > > > >
> > > > > It is not quite correct. The tests passes on Windows but fails on
> Linux
> > > > -
> > > > > I'm going to investigate the difference. But if I remove these
> lines
> > > > then it
> > > > > will fail on Windows too.
> > > > >
> > > > > IMHO, we should avoid making unrelated changes in a single commit.
> > > > >
> > > > >
> > > > < SNIP>
> > > >
> > > > --
> > > > Mark Hindess <mark.hindess@googlemail.com>
> > > > IBM Java Technology Centre, UK.
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Thanks,
> > > Stepan Mishura
> > > Intel Middleware Products Division
> > >
> > > ------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Mark Hindess <mark.hindess@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
>
>
> --
> Mark Hindess <mark.hindess@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--
Thanks,
Stepan Mishura
Intel Middleware Products Division

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message