harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Date Wed, 19 Apr 2006 04:34:28 GMT
On 4/18/06, Mark Hindess wrote:
>
> Stepan,
>
> Sorry.  I didn't mean to blame you.  I did realise that you were just
> putting it back to the "initial" style.


Mark, I also expected that you didn't want to blame me :-) As far as English
is not my native language I used to read messages in a way like my good
friend points out to my mistakes (except if a message is not obviously
rude).


> Since you asked (well almost ;-) I'm in favour of 4 space indent since
> this is quite common in the java code.  Unlike Geir I don't mind if
> tabs are used but they should always be treated as being equivalent to
> 8 spaces.  Though I'd might change my mind if I understood the
> motivation behind Geir's aversion to tabs.


OK. If there will be no objections I'm going to replace tabs with 4 space
indent in build files.

Thanks,
Stepan.

Regards,
> Mark.
>
> On 4/18/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > Mark,
> >
> > The update only adjusts build files to *initial* style (that is
> tabs-style).
> >
> > IMHO really doesn't matter how many spaces in one tab if you follow one
> > style in a file and don't mix tabs with spaces. Also I like
> > tab-style because I have opportunity to choose a number of spaces that
> more
> > suitable for my eyes. If everybody will agree to use only space-style
> then
> > OK - I'll fix tabs.
> >
> > Thanks,
> > Stepan.
> >
> >
> > On 4/18/06, Mark Hindess wrote:
> > >
> > > For many people however tabs are equivalent to 8 spaces so if what we
> > > really intend is 4 spaces then perhaps we should make them spaces not
> > > tabs?
> > >
> > > Otherwise we will be forever fixing identations because of editor
> > > differences.
> > >
> > > -Mark.
> > >
> > > On 4/18/06, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > > > On 4/18/06, Mark Hindess wrote:
> > > > >
> > > > > Stepan,
> > > > >
> > > > > Just curious what you are fixing here?  Changing 8 spaces to tabs?
> > > > > Why does this matter?  Shouldn't tabs (at the beginning of a line)
> > > > > always be equivalent to 8 spaces?
> > > >
> > > >
> > > > Mark,
> > > >
> > > > I'd prefer to have all build files follow one style - I don't like
> > > mixing
> > > > tabs and spaces even they looks the same. For this particular case -
> > > build
> > > > files were initially created using tabs and I'd prefer to keep this
> > > style.
> > > > Also for me tab is not equivalent to 8 spaces - Eclipse sets tab
> > > equivalent
> > > > to 4 spaces and I'm not going to change it because I like it :-)
> > > >
> > > > Thanks,
> > > > Stepan.
> > > >
> > > > Incidentally, I think 8 character indentations are excessive.  Quite
> a
> > > > > few of the ant files use 4 character indentations which I find
> much
> > > > > easier to read.  Ditto for java code.  Perhaps we could agree
> which to
> > > > > use?
> > > > >
> > > > > Regards,
> > > > > -Mark - wondering if he might regret asking this
> > > > >
> > > > > On 4/18/06, smishura@apache.org <smishura@apache.org> wrote:
> > > > > > Author: smishura
> > > > > > Date: Tue Apr 18 02:38:29 2006
> > > > > > New Revision: 394890
> > > > > >
> > > > > > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > > > > > Log:
> > > > > > Correcting indentation
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> > > > > >
> > > > > > Modified:
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > > URL:
> > > > >
> > >
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> > > > > >
> > > > >
> > >
> ==============================================================================
> > > > > > ---
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > (original)
> > > > > > +++
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > Tue Apr 18 02:38:29 2006
> > > > > > @@ -68,12 +68,12 @@
> > > > > >
> > > > > >
> > > > > >         <target name="run.tests">
> > > > > > -
> > > > > > -               <mkdir dir="${hy.tests.reports}" />
> > > > > > +
> > > > > > +               <mkdir dir="${hy.tests.reports}" />
> > > > > >
> > > > > >                 <property name="test.jre.home" value="${
> hy.target
> > > }/jre"
> > > > > />
> > > > > >
> > > > > > -               <junit fork="yes"
> > > > > > +               <junit fork="yes"
> > > > > >                         forkmode="once"
> > > > > >                         printsummary="withOutAndErr"
> > > > > >                         errorproperty="test.errors"
> > > > > >
> > > > > > [ SNIP ]
> > > > >
> > > > > --
> > > > > Mark Hindess <mark.hindess@googlemail.com>
> > > > > IBM Java Technology Centre, UK.
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > -----------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > > Thanks,
> > > > Stepan Mishura
> > > > Intel Middleware Products Division
> > > >
> > > >
> > >
> > >
> > > --
> > > Mark Hindess <mark.hindess@googlemail.com>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > -----------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> > Thanks,
> > Stepan Mishura
> > Intel Middleware Products Division
> >
> >
>
>
> --
> Mark Hindess <mark.hindess@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--
-----------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Thanks,
Stepan Mishura
Intel Middleware Products Division

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message