harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Loenko, Mikhail Y" <mikhail.y.loe...@intel.com>
Subject RE: [jira] Updated: (HARMONY-353) improvements to junit test method usage
Date Mon, 17 Apr 2006 12:45:48 GMT
Hi Mark,

During that short period of time when JIRA was up I've tried to apply
the patches in the order described here, but got lots of errors. For
example 01.assertnull.diff goes OK when applied the first but reports
errors when applied after improved.assertequals.usage.diff.

Could you please submit all the changes in a single patch?


>-----Original Message-----
>From: Mark Hindess (JIRA) [mailto:jira@apache.org]
>Sent: Monday, April 17, 2006 12:00 AM
>To: harmony-commits@incubator.apache.org
>Subject: [jira] Updated: (HARMONY-353) improvements to junit test
method usage
>     [ http://issues.apache.org/jira/browse/HARMONY-353?page=all ]
>Mark Hindess updated HARMONY-353:
>    Attachment: 04.assertequals.char.constants.diff
>                05.assertnotnull.diff
>04 fixes assertTrue(... == 'c') to assertEquals
>05 fixes assertTrue(... != null) to assertNotNull
>> improvements to junit test method usage
>> ---------------------------------------
>>          Key: HARMONY-353
>>          URL: http://issues.apache.org/jira/browse/HARMONY-353
>>      Project: Harmony
>>         Type: Improvement
>>   Components: Classlib
>>     Reporter: Mark Hindess
>>     Priority: Trivial
>>  Attachments: 01.assertnull.diff, 02.assertequals.string.diff,
>04.assertequals.char.constants.diff, 05.assertnotnull.diff,
>> While fixing the test in HARMONY-352, I found some confusing junit
>> error messages.  They were things like:
>>   error expected <actual> but got <expected>
>> rather than:
>>   error expected <expected> but got <actual>
>> Because the arguments to the assertEquals method were the wrong way
>> around.  The expected value should come first.  Anyway, I fixed these
>> for that one test.  We should try to fix these when we find them and
>> we should try to avoid adding any more.
>> This JIRA is because I decided that it was reasonable to fix any
method like:
>>   assertEquals(..., <constant>);
>> since a constant couldn't very well be the value being tested.
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly contact one of the administrators:
>   http://issues.apache.org/jira/secure/Administrators.jspa
>For more information on JIRA, see:
>   http://www.atlassian.com/software/jira

Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

View raw message