harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "LvJimmy,Jing" <firep...@gmail.com>
Subject Re: Long,long testcase name...
Date Mon, 17 Apr 2006 01:30:45 GMT
2006/4/16, Nathan Beyer <nbeyer@kc.rr.com>:
>
>
> > -----Original Message-----
> > From: LvJimmy,Jing [mailto:firepure@gmail.com]
> > Sent: Saturday, April 15, 2006 9:45 PM
> > To: harmony-dev@incubator.apache.org
> > Subject: Re: Long,long testcase name...
> >
> > 2006/4/16, Nathan Beyer <nbeyer@kc.rr.com>:
> > >
> > > +1
> > >
> > > I think "use your good judgment" is a great comment on this whole
> topic
> > > (and
> > > others). Let contributors submit test code based on their judgment and
> > let
> > > committers massage and/or commit based on their best judgment. If
> > another
> >
> >
> > :) That's right everyone believe in his judgment, so the code shall be
> in
> > variety of styles. I believe most of them are correct and good, but
> maybe
> > some of them are not, or some developers do not have their own idea of
> > naming orstyle, so offer a model/example here is useful.
> >
>
> [Nathan Beyer] I would argue that the code that exists in the repository
> is
> a sufficient example and guideline. If it's not, then patches should be
> submitted with rationales that validate the change.
>
> > contributor or committer feels that a refactoring would be helpful, then
> > let
> > > the process work.
> >
> >
> > No one would like his code changed by others ... Why not make it
> > acceptable
> > for everyone at the first time? It won't waste time. :)
>
> [Nathan Beyer] Maybe I'm pessimistic, but when I write code for open
> source
> projects I assume that my code will be changed. It isn't my code; it's the
> project's code because I donated it and the project can do as it pleases
> with it. If my code is committed without change, then great; if it is
> changed, then that's just as great because my code was accepted and I get
> to
> learn something.


Right, right, it's the project's code then. I mean, shall someone apply a
patch only for re-naming? That's waste of time. Why not learn ahead of
writing something, or follow the convention?

In any case, is it realistic to think that one particular style or
> convention is going to be acceptable by everyone? At some point the
> acceptability of a piece of code will come down to one person's judgment
> and
> their view of what's acceptable at that moment in time.


one particular style may not be accepted by everyone, but convention is just
another thing. What's more, naming convention can help everyone. Indeed, I
do not care what the convention is after it's agreed, but it is important we
get one and follow.
Anyway, convention is not one man's judgment or view, it is something
discussed,compromise, then accepted by everyone, right? :)

>
> > -Nathan
> > >
> > > > -----Original Message-----
> > > > From: Geir Magnusson Jr [mailto:geir@pobox.com]
> > > >
> > > >
> > >
> >
> test<SomethingUsefulWithMaybeANumberIfItsOverloadedWhereYouUseYourGoodJudg
> > > > ement>
> > > >
> > > > or
> > > >
> > > >
> > >
> >
> test<SomethingThatYouWouldLikeToEncounterIfYouWereReadingCodeForFirstTime>
> > > >
> > > > but not
> > > >
> > > > test<SomethingDogmaticJustForSakeOfDogma>
> > > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> >
> > Best Regards!
> >
> > Jimmy, Jing Lv
> > China Software Development Lab, IBM
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message