harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [classlib] Testing
Date Thu, 27 Apr 2006 08:16:54 GMT


Mikhail Loenko wrote:
> Geir,
> 
> The problem is that no one yet suggested a consistent solution
> that would fit for all the tests and would not get into packages like
> 
> org.apache.harmony.security.tests.org.apache.harmony.security.util
> 
> 
> Everybody seems to agree that SOME implementation specific tests are
> in the same package as implementation.
> 
> But if we have ALL the tests in the same package as implementation,
> then we can't run e.g. tests against java.beans.Beans from classpath, so
> we can't run regression test for HARMONY-358

Right - I thought that some tests can't be in implementation package - 
i.e. the API tests that we wish to run on classpath - and therefore we 
put those somewhere else.

I thought that "somewhere else" was  o.a.security.tests.<whatever>

> 
> The question is where we put 'classpath'  test. If we put them into
> o.a.h.module.tests.[package under test] we result in that ugly package
> names like
> o.a.h.security.tests.o.a.h.security.util

Why not

    o.a.h.security.tests.util

?

geir


> 
> Thanks,
> Mikhail
> 
> 
> 2006/4/27, Geir Magnusson Jr <geir@pobox.com>:
>> Geir Magnusson Jr wrote:
>>> George Harley wrote:
>>  >>
>>>> Of course, the text module has only "implementation-independent tests
>>>> that designed to be run from classpath". For modules that have got
>>>> implementation-specific tests then I suppose we could use something
>>>> like "org.apache.harmony.[module].tests.impl.[package under test]" or
>>>> "org.apache.harmony.[module].tests.internal.[package under test]" etc.
>>>> I've got no preference.
>>> -1
>>>
>>> Put them in the same package as the class being tested, please, if there
>>> is no problem being run that way.
>> Sorry to be so snippy.  Been a long day.
>>
>> Why would we want this convoluted package name?  Why wouldn't we want to
>> let them be in the same package as the class being tested since it's
>> implementation testing?
>>
>> geir
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message