harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Date Tue, 18 Apr 2006 11:57:10 GMT
Wait - no tabs!  no tabs!  PLEASE!

You can have your 1,743 character test case names if you want, but NO 
TABS! :)

geir

Mark Hindess wrote:
> Stepan,
> 
> Just curious what you are fixing here?  Changing 8 spaces to tabs?
> Why does this matter?  Shouldn't tabs (at the beginning of a line)
> always be equivalent to 8 spaces?
> 
> Incidentally, I think 8 character indentations are excessive.  Quite a
> few of the ant files use 4 character indentations which I find much
> easier to read.  Ditto for java code.  Perhaps we could agree which to
> use?
> 
> Regards,
> -Mark - wondering if he might regret asking this
> 
> On 4/18/06, smishura@apache.org <smishura@apache.org> wrote:
>> Author: smishura
>> Date: Tue Apr 18 02:38:29 2006
>> New Revision: 394890
>>
>> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
>> Log:
>> Correcting indentation
>>
>> Modified:
>>     incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
>>     incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
>> ==============================================================================
>> --- incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
(original)
>> +++ incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
Tue Apr 18 02:38:29 2006
>> @@ -68,12 +68,12 @@
>>
>>
>>         <target name="run.tests">
>> -
>> -               <mkdir dir="${hy.tests.reports}" />
>> +
>> +               <mkdir dir="${hy.tests.reports}" />
>>
>>                 <property name="test.jre.home" value="${hy.target}/jre" />
>>
>> -               <junit fork="yes"
>> +               <junit fork="yes"
>>                         forkmode="once"
>>                         printsummary="withOutAndErr"
>>                         errorproperty="test.errors"
>>
>> [ SNIP ]
> 
> --
> Mark Hindess <mark.hindess@googlemail.com>
> IBM Java Technology Centre, UK.
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message