harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paulex Yang <paulex.y...@gmail.com>
Subject Re: Patches to fix java.lang [Was: Fixing java.lang]
Date Mon, 03 Apr 2006 09:47:07 GMT
Etienne,

FYI,

There are some helper classes on serialization test, which may make 
serialization testcases easier to create. hmmm..., in fact, *some* here 
means two, which come with contributions of different components from 
different ones, and people here haven't decided how to merge them:-(. 
One[1] is a abstract test case, which can be extended to create 
customized serialization test, the other[2] provides some util methods. 
IMO, both are handy, and you can choose any of them, and maybe provide 
some good suggestions on the merge issue.

[1] 
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/modules/security/test/common/unit/org/apache/harmony/security/test/SerializationTest.java?rev=378448&view=markup
[2] 
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/support/src/test/java/tests/util/SerializationTester.java?rev=386058&view=markup

Tim Ellison wrote:
> Etienne,
>
> It would be helpful if you could also include a regression test case to
> ensure that the serialized form is the same as the reference
> implementation.  We do that by storing the serialized form of an object
> as written using the reference implementation.
>
> Regards,
> Tim
>
> Etienne Gagnon wrote:
>   
>> Hi Geir,
>>
>> So, it's time for me to learn, slowly, the customs of the Harmony
>> project.  I'm ready to contribute the following 4 very modest patches.
>>
>> FYI, I seeked the SerialVersionUIDs in Sun's public API:
>>   http://java.sun.com/j2se/1.5.0/docs/api/serialized-form.html
>>
>> What's the usual procedure?  [both in the legal sense and the technical one]
>>
>> Thanks for your patience helping a newbie,
>>
>> Etienne
>>
>> PS: I can make it into one patch.  I am just trying to figure out the
>> desired granularity for contributions.
>>
>> Magnusson, Geir wrote:
>>     
>>> Thanks for volunteering.....  :)
>>>       
>> 	
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/IllegalArgumentException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/IllegalArgumentException.java	(revision
390759)
>> +++ modules/luni/src/main/java/java/lang/IllegalArgumentException.java	(working copy)
>> @@ -22,6 +22,8 @@
>>   */
>>  public class IllegalArgumentException extends RuntimeException {
>>  
>> +	private static final long serialVersionUID = -5365630128856068164L;
>> +
>>  	/**
>>  	 * Constructs a new instance of this class with its walkback filled in.
>>  	 */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/IllegalStateException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/IllegalStateException.java	(revision 390759)
>> +++ modules/luni/src/main/java/java/lang/IllegalStateException.java	(working copy)
>> @@ -22,6 +22,8 @@
>>   */
>>  public class IllegalStateException extends RuntimeException {
>>  
>> +	private static final long serialVersionUID = -1848914673093119416L;
>> +
>>  	/**
>>  	 * Constructs a new instance of this class with its walkback filled in.
>>  	 */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/SecurityException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/SecurityException.java	(revision 390759)
>> +++ modules/luni/src/main/java/java/lang/SecurityException.java	(working copy)
>> @@ -21,6 +21,8 @@
>>   */
>>  public class SecurityException extends java.lang.RuntimeException {
>>  
>> +	private static final long serialVersionUID = 6878364983674394167L;
>> +
>>  	/**
>>  	 * Constructs a new instance of this class with its walkback filled in.
>>  	 */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/UnsupportedOperationException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/UnsupportedOperationException.java	(revision
390759)
>> +++ modules/luni/src/main/java/java/lang/UnsupportedOperationException.java	(working
copy)
>> @@ -21,6 +21,8 @@
>>   */
>>  public class UnsupportedOperationException extends RuntimeException {
>>  
>> +	private static final long serialVersionUID = -1242599979055084673L;
>> +
>>  	/**
>>  	 * Constructs a new instance of this class with its walkback filled in.
>>  	 */
>>     
>
>   


-- 
Paulex Yang
China Software Development Lab
IBM



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message