Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of stepan.mishura@gmail.com
 designates 64.233.182.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=LSc5L7HJtEZIVnbYSNN7ReBtGdDDb/zDdd2B1ZSJgk/2GnGCntIC2BOz9pBXenpPCdzOL3XwnjFHTvMiwOcuf9jVMGSr++rMagBeALWn4XtNy0vZP0qqrAA5kytxsOWVSIK6jwyEyF2+g9AUJPJeBMFd5BpxEQRhxx0FdQqbXGg=
Message-ID: <6e47b64f0603272047p11b2dd61x6a6ae4991b065a36@mail.gmail.com>
Date: Tue, 28 Mar 2006 11:47:06 +0700
From: "Stepan Mishura" <stepan.mishura@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Updated: (HARMONY-250) disambiguate some error messages
In-Reply-To: <44284F20.6070902@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_4356_33158488.1143521226872"
References: <1244426620.1143233479935.JavaMail.jira@ajax>
	 <44284F20.6070902@gmail.com>

------=_Part_4356_33158488.1143521226872
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Tim,

I agree with you that this should be fixed. I found the similar case in
javax.crypto.CipherSpi class
I'm going to fill new JIRA tracker, scan all code in security module and fi=
x
all such cases.

May be in makes sense to avoid patches conflict apply this patch first and
next patch will fix the issue with exception.

Thanks,
Stepan.

On 3/28/06, Tim Ellison wrote:
>
> Why does the javax.crypto.spec.SecretKeySpec create an exception eagerly
> in a static?
>
> >  private static final IllegalArgumentException BADPARAMS_EXC =3D
> >   new IllegalArgumentException(
> >    "algorithm is null or key is null, empty, or too short.");
>
> If the exception is thrown it is not going to have a useful stack to
> help debug the cause of the bad parameters.
>
> Regards,
> Tim
>
> Mark Hindess (JIRA) wrote:
> >      [ http://issues.apache.org/jira/browse/HARMONY-250?page=3Dall ]
> >
> > Mark Hindess updated HARMONY-250:
> > ---------------------------------
> >
> >     Attachment: disambiguate.error.messages.diff
> >
> > Patch to split some error messages in to more less ambiguous messages.
> >
> >
> >> disambiguate some error messages
> >> --------------------------------
> >>
> >>          Key: HARMONY-250
> >>          URL: http://issues.apache.org/jira/browse/HARMONY-250
> >>      Project: Harmony
> >>         Type: Improvement
> >>   Components: Classlib
> >>     Reporter: Mark Hindess
> >>     Priority: Trivial
> >>  Attachments: disambiguate.error.messages.diff
> >>
> >> As discussed on the -dev list, some exceptions are too ambiguous.  I
> will attach a patch to fix some of them.
> >
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>


--
Thanks,
Stepan Mishura
Intel Middleware Products Division

------=_Part_4356_33158488.1143521226872--