Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 60000 invoked from network); 29 Mar 2006 21:15:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 Mar 2006 21:15:20 -0000 Received: (qmail 17073 invoked by uid 500); 29 Mar 2006 21:15:17 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 17027 invoked by uid 500); 29 Mar 2006 21:15:16 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 17015 invoked by uid 99); 29 Mar 2006 21:15:16 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Mar 2006 13:15:16 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 217.158.94.220 is neither permitted nor denied by domain of t.p.ellison@gmail.com) Received: from [217.158.94.220] (HELO cirrus.purplecloud.com) (217.158.94.220) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Mar 2006 13:15:15 -0800 Received: (qmail 55650 invoked from network); 29 Mar 2006 22:14:54 +0100 Received: from unknown (HELO ?192.168.0.2?) (85.133.120.161) by smtp.purplecloud.net with (DHE-RSA-AES256-SHA encrypted) SMTP; 29 Mar 2006 22:14:53 +0100 Message-ID: <442AF8CD.6040004@gmail.com> Date: Wed, 29 Mar 2006 22:14:53 +0100 From: Tim Ellison User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: harmony-dev@incubator.apache.org Subject: EOL differences in svn diffs References: <1988982437.1143644491843.JavaMail.jira@ajax> In-Reply-To: <1988982437.1143644491843.JavaMail.jira@ajax> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Nikolay Kuznetsov (JIRA) wrote: > Nikolay Kuznetsov commented on HARMONY-271: > ------------------------------------------- > > Tim, > > tank you very much for so such a quick response and integration. All the changes are in place as was expected. > But there is one minor issue, affected files was somehow(svn commit, I believe) converted into dos format(line terminators was changed for entire files). > It's not a problem itself, but svn diff shows that entire file was changed during this commit. Yes, I saw that too, and I agree that it makes it virtually impossible to see exactly what was changed. I used a windows machine to apply your patch and commit the code, so I can only assume that's why the file was converted to DOS EOL. I'll poke around to see if I can make it preserve the incoming EOL convention. Regards, Tim -- Tim Ellison (t.p.ellison@gmail.com) IBM Java technology centre, UK.