harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry M. Kononov" <dmitry.m.kono...@gmail.com>
Subject Re: [jira] Updated: (HARMONY-156) InputStreamReader.getEncoding() and OutputStreamWriter.getEncoding() should return a historical charset name.
Date Thu, 09 Mar 2006 13:40:57 GMT
Paulex,

I have some thoughts about the patch. It looks good but the following two
things:

1) java/io/InputStreamReader.
getHistoricalName(String name) should not be public I think.

2) java/io/OutputStreamWriter.getEncoding().
You probably meant

if (!isOpen()) {
    return null;
}

instead of

if (encoder == null) {
    return null;
}

since this method returns null if the stream has been closed.

Thanks.

On 3/8/06, Paulex Yang (JIRA) <jira@apache.org> wrote:
>
>     [ http://issues.apache.org/jira/browse/HARMONY-156?page=all ]
>
> Paulex Yang updated HARMONY-156:
> --------------------------------
>
>    Attachment: patch_156.txt
>                patch_156_test.txt
>
> As no one has better idea than my prior proposal, i.e., save the mapping
> between historical name and canonical name, I created the patch for this
> solution. The affected package is luni/java.io.
>
> --
> Dmitry M. Kononov
> Intel Managed Runtime Division

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message