harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: And enum types (Re: API with generics)
Date Wed, 15 Mar 2006 09:52:35 GMT
Hi Paulex,

We also had problem with enums while developing security package.
Finally, we made it 1.5 compliant, tested with BEA 1.5 and commented out

See
modules/security/src/common/javasrc/java/security/KeyRep.java

Thanks,
Mikhail

2006/3/15, Paulex Yang <paulex.yang@gmail.com>:
> Nathan Beyer wrote:
> > My approach has been to make the APIs as close to possible as the Java 5
> > spec
> Agree.  Another issue is enum, for example,
>
> public enum SomeEnum{
>    enum1, enum2, enum3
> }
>
> I think the mimic will look like:
>
> public final class SomeEnum extends Enum{
>    public static final SomeEnum enum1 =  new SomeEnum("enum1", 0);
>    public static final SomeEnum enum2 = new SomeEnum("enum2", 1);
>    public static final SomeEnum enum3 = new SomeEnum("enum3", 2);
>
>    protected SomeEnum(String name, int |ordinal|){
>       super(name, ordinal).
>    }
> }
>
> and of course, the abstract class Enum(declaration without generics of
> course) must exist at first.
>
> Thoughts?  I will raise a jira about Enum abstract class and create a
> patch later to support this mimic if this approach is fine.
> > and then leave //TODO comments about what needs to be added and what is
> > needed to fix it or what is preventing completion.
> >
> > The same condition applies to annotations and methods that take advantage of
> > return type covariance.
> >
> > We could consider creating a comment practice to flag specific changes.
> > Perhaps something like this:
> >
> > //HARMONY_GENERICS <Type> comment
> > //HARMONY_ANNOTATION @annotation comment
> > //HARMONY_COVARIANT_RETURN Type comment
> >
> > In Eclipse's Java editor you can add special meaning to comments of a
> > certain format, so this could be taken advantage of there at least.
> >
> > -Nathan
> >
> > -----Original Message-----
> > From: karan malhi [mailto:karan.malhi@gmail.com]
> > Sent: Tuesday, March 14, 2006 8:04 PM
> > To: harmony-dev@incubator.apache.org
> > Subject: API with generics
> >
> > Hi,
> >
> > I might have missed out on it in earlier discussions so please excuse me
> > for my ignorance. What is the strategy of harmony with regards to
> > Generics? To be more specific, I am right now implementing the
> > javax.accessibility.AccessibleStateSet class which has a protected
> > variable with the following signature:
> >
> >     protected Vector<AccessibleState> states
> >
> > My understanding is that currently generics are not supported. What
> > should I do in this case? Should I just implement it without generics?
> > Is there a webpage where we are listing api methods/fields which involve
> > generics to later on update the code?
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>

Mime
View raw message