harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: svn commit: r386058 [1/49] ...
Date Sat, 18 Mar 2006 22:17:02 GMT


Mark Hindess wrote:
> On 3/16/06, Magnusson, Geir <geir.magnusson@intel.com> wrote:
>> What was I concerned about?
> 
> ...
> 
> On Mar 3, 2006 11:36 AM you wrote:
>> Mark Hindess wrote:
>>
>>> I've been spending a little time fixing up contributions that I think
>>> are worthwhile - mostly patches that have been broken by the recent
>>> shared native code moves that Tim committed.  I'm willing to do this
>>> because I broke them ;-) but mostly because I know it helps reduce the
>>> load on committers and because having your patch broken/delayed can be
>>> discouraging for new contributors.
>> I'm actually a little worried about patches to patches because then the
>> provenance becomes unclear if there's a problem in the future.  Hm.
> 
> Which seemed to me to be a fairly reasonable concern.
> 

Yes - ok.  I guess there's a difference between a code fix kind of patch 
and a "hey, this new build target for ant", but maybe not.

Something to ponder...

geir


Mime
View raw message