harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: svn commit: r386058 [1/49] ...
Date Wed, 15 Mar 2006 19:52:59 GMT
I did my usual trick, which is to mention the JIRA tag and the issue
summary; in this case it was:

In "svn commit: r386087 [1/45] -..."

<snip>
Log:
Commit contribution HARMONY-88 (Contribution of code and unit tests for
jndi, logging, prefs and sql plus unit tests only for beans, crypto,
math, regex and security)
<snip>

and in "svn commit: r386058 [1/49] -..."

<snip>
Log:
Apply HARMONY-57 (Contribution of unit test code for a number of components)
<snip>


I did them as a single commit, so I assume it is the SVN mail notifier
that splits the single r386058 message into 49 pieces due to length.

Regards,
Tim


Magnusson, Geir wrote:
> I assume that you noted the jura entry in the commit log.....
> 
>  -----Original Message-----
> From: 	Tim Ellison [mailto:t.p.ellison@gmail.com]
> Sent:	Wed Mar 15 11:44:19 2006
> To:	harmony-dev@incubator.apache.org
> Subject:	Re: svn commit: r386058 [1/49] ...
> 
> Yes, the log message is only shown in the first commit message in the set.
> 
> That particular commit is the HARMONY-57 bulk contribution that was
> voted on by the -dev list.  The other big commit I did today is the
> HARMONY-88 bulk contribution that was also accepted by the -dev list.
> 
> I'm not *that* productive!
> 
> Regards,
> Tim
> 
> 
> Magnusson, Geir wrote:
>> Isn't this the initial commit for somwthing we just voted in?
>>
>> (me in car so can't see right now....)
>>
>>  -----Original Message-----
>> From: 	Leo Simons [mailto:mail@leosimons.com]
>> Sent:	Wed Mar 15 11:34:35 2006
>> To:	harmony-dev@incubator.apache.org
>> Subject:	Re: svn commit: r386058 [1/49] ...
>>
>> 49 commit messages for a single commit! The continuous wash-in of
>> Really Big(tm) chunks of code scares me a little (even if its real cool)
>>  -- usually I make it policy to read every single line of code contributed
>> to a project for which I'm on the PMC but there's no chance in hell I'm
>> going to spend an entire weekend reading unit tests. Just keeping up amounts
>> to something close to a fulltime job. The "usual" "oversight" model that at
>> least some parts of the ASF are used to seems near-impossible to apply here.
>>
>> Will all people able to read every line of code as it comes in please raise
>> their hands?
>>
>> I'm thinking about how to make this stuff scale. Any ideas? The natural
>> tendency is to want to partition, but that way we lose the "many eyes"
>> advantages....
>>
>> Anyway, just a random thought...
>>
>> - Leo
>>
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

Mime
View raw message