harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: Location of test data files
Date Mon, 13 Mar 2006 23:49:17 GMT


George Harley wrote:
> Richard Liang wrote:
>> George Harley wrote:
>>> Hi Mikhail (again),
>>>
>>> Just a couple of brief observations about the SerializationTest.java 
>>> code as it stands in SVN today :
>>>
>>> 1) The reference/golden .dat files for Serializable classes in a 
>>> given module could be added under the module's src/test/resources 
>>> directory (in sub-folders corresponding to their package names). In 
>>> an Ant build these would be copied under the test bin using a tweaked 
>>> version of the "copy-test-resources" target (see the proposed changes 
>>> to make/build-java.xml contained in the HARMONY-57). At runtime this 
>>> would make the .dat files available from the classpath.
>>>
>> Hello George,
>>
>> It's good to put all test data files for one module into one folder, 
>> such as "src/test/resources". However, there may be other options, 
>> personally I'd like to put the test data file into the same directory 
>> of the test case which uses the data file. This may make the 
>> maintenance work easy. :-)
>> Anyway, I think we shall follow the same style.
> 
> Hi Richard,
> 
> Just to avoid any ambiguity here, what I proposed was to place the 
> reference serialization files *under* a given module's 
> src/test/resources folder in sub-folders that matched the package name 
> of the test class - and not just have them all in one folder.
> 

Great - that wasn't clear.  This works for me.

geir

Mime
View raw message