harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leo Simons <m...@leosimons.com>
Subject Re: svn commit: r386058 [1/49] ...
Date Thu, 16 Mar 2006 16:31:37 GMT
Hi gang,

just in case it wasn't clear - I understand where the commit came from and
I am not questioning it or the stuff contributed or the matter by which it
came in at all (insane amounts of quality code is a Good Thing). We should
not in any way "rate limit" our development and the process we have in place
for these bulk contributions is the best I can think of (or I'd suggest
changing it). Kudos to the people contributing it and kudos for Tim for working
on integrating it.

I just feel "oversight" is not scaling along with the project size, just
because that is probably impossible. Even if we have few bulk commits, we
have huge areas of codebase where there will be commits, and not so many
people knowing that codebase well enough to be able to fully understand
the commit.

To explain oversight a little further -- for every line of the Apache HTTPD
server code (at least the core, not all modules), it is likely that it has
been read and/or examined in detail by at least a dozen people. We probably
now have two lines of test case for every line of code in HTTPD so we get
nowhere close to their level of "many eyes to find bugs".

This is not neccessarily a "problem" and certainly not a short-term issue.
We just need to work on "scaling", something that interests me a lot (which
I try and find time to work on Gump when I can).



On Wed, Mar 15, 2006 at 07:42:21PM +0000, Tim Ellison wrote:
> Yes, the log message is only shown in the first commit message in the set.
> That particular commit is the HARMONY-57 bulk contribution that was
> voted on by the -dev list.  The other big commit I did today is the
> HARMONY-88 bulk contribution that was also accepted by the -dev list.
> I'm not *that* productive!
> Regards,
> Tim
> Magnusson, Geir wrote:
> > Isn't this the initial commit for somwthing we just voted in?
> > 
> > (me in car so can't see right now....)
> > 
> >  -----Original Message-----
> > From: 	Leo Simons [mailto:mail@leosimons.com]
> > Sent:	Wed Mar 15 11:34:35 2006
> > To:	harmony-dev@incubator.apache.org
> > Subject:	Re: svn commit: r386058 [1/49] ...
> > 
> > 49 commit messages for a single commit! The continuous wash-in of
> > Really Big(tm) chunks of code scares me a little (even if its real cool)
> >  -- usually I make it policy to read every single line of code contributed
> > to a project for which I'm on the PMC but there's no chance in hell I'm
> > going to spend an entire weekend reading unit tests. Just keeping up amounts
> > to something close to a fulltime job. The "usual" "oversight" model that at
> > least some parts of the ASF are used to seems near-impossible to apply here.
> > 
> > Will all people able to read every line of code as it comes in please raise
> > their hands?
> > 
> > I'm thinking about how to make this stuff scale. Any ideas? The natural
> > tendency is to want to partition, but that way we lose the "many eyes"
> > advantages....
> > 
> > Anyway, just a random thought...

View raw message