harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from NIO to LUNI
Date Fri, 17 Feb 2006 10:50:12 GMT

I have had a look at your patch, but not applied it ...

I agree with moving this behavior into LUNI, but perhaps you would
consider refactoring to remove the distinction between platform and
platform.struct (which is historical), and adopting the proposed package
naming we have discussed on the list.  So if you could refactor into
o.a.h.luni.platform and o.a.h.luni.internal.platform that would be better.

You also need to update the manifest files to reflect the package
refactoring, and the build patternsets.

What do you think?


Richard Liang (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]
> Richard Liang updated HARMONY-92:
> ---------------------------------
>     Attachment: refactor_platform.zip
> Hello,
> Here is the patch for this issue.
> 1. For java source, it's more convenient to use Eclipse's refact->move, rename (You
can also copy files from the attachment)
> 2. For native source, please copy files from the attachment, then apply the patch file.

> (Though there are only some copy, paste, delete, and rename operations, we have done
it for you.)
> Thanks a lot.
>> Suggestion: Move com.ibm.platform from NIO to LUNI
>> --------------------------------------------------
>>          Key: HARMONY-92
>>          URL: http://issues.apache.org/jira/browse/HARMONY-92
>>      Project: Harmony
>>         Type: Improvement
>>   Components: Classlib
>>     Reporter: Richard Liang
>>  Attachments: refactor_platform.zip
>> Hello Tim,
>> As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform
and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net,
as well as java.nio.channels. I will post the proposed fix soon :-)


Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

View raw message