harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [classlib] do we need a global exclude list?
Date Thu, 16 Feb 2006 15:35:46 GMT
Geir Magnusson Jr wrote:
> 
> 
> Tim Ellison wrote:
>>
>> The exclusion list is implemented as a (declarative) XML file read when
>> the tests run -- in HARMONY-57 you can see one in
>> Harmony_Tests/src/test/resources/config/jcltest-excludes.xml
>>
>> Picking an entry at random from there:
>>     ...
>>     <hy:type id="tests.api.java.io.FileTest">
>>         <hy:exclude id="test_Constructor_String_String_112270"
>>                     shouldfix="true">
>>             <hy:reason>Undiagnosed failure</hy:reason>
>>         </hy:exclude>
>>         <hy:exclude id="test_Constructor_File_String_112270"
>>                     shouldfix="true">
>>             <hy:reason>Undiagnosed failure</hy:reason>
>>         </hy:exclude>
>>         <hy:exclude id="test_deleteOnExit" shouldfix="true">
>>             <hy:reason>Needs investigation...</hy:reason>
>>         </hy:exclude>
>>     </hy:type>
>>     ...
>>
>> You can see how it works -- some tests are excluded because they fail
>> and should be fixed, others (not shown here) can be excluded because
>> they don't make sense on a particular platform, VM, etc.
>>
>> Applying a style sheet makes it easy to read the exclusions list in
>> glorious technicolor, either in an individual module or as a combined
>> global view.
>>
> 
> That's cute.  And if these were local to each module, in a "well-known"
> place, we still could present a global picture with a top level thingy
> that generates a list...

Yep, probably putting the exclusion list into src/test/resources in each
module, and like you say, easy to combine.

> We could also add a platform element to make exclusions platform
> specific...

Already there ;-)

<xsd:element name="exclude">
  <xsd:complexType>
    <xsd:sequence>
      <xsd:element ref="reason" minOccurs="0" maxOccurs="1"/>
    </xsd:sequence>
    <xsd:attribute name="id"
                   type="idtype"
                   default="all" />
    <xsd:attribute name="platform"
                   type="platformlisttype"
                   default="all" />
    <xsd:attribute name="shouldfix"
                   type="booleanstringtype"
                   default="true" />
  </xsd:complexType>
</xsd:element>

where

<xsd:simpleType name="platformstringtype" >
  <xsd:restriction base="xsd:string">
    <xsd:enumeration value="win.IA32"/>
    <xsd:enumeration value="linux.IA32"/>
    <xsd:enumeration value="all"/>
  </xsd:restriction>
</xsd:simpleType>

but of course we can do whatever we want.

Regards,
Tim

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

Mime
View raw message