harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-123) Refactor: java.nio.charset.CharsetDecoder.decode
Date Thu, 23 Feb 2006 14:26:39 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-123?page=all ]
Tim Ellison resolved HARMONY-123:

    Resolution: Fixed


Thanks for the patch, it has been applied to NIO_CHAR java.nio.charset.CharsetDecoder at repo
revision 380121.

Please check that the patch was applied as you expected.

> Refactor: java.nio.charset.CharsetDecoder.decode
> ------------------------------------------------
>          Key: HARMONY-123
>          URL: http://issues.apache.org/jira/browse/HARMONY-123
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Tim Ellison
>     Priority: Minor
>  Attachments: CharsetDecoder_patch.txt
> I've refactored two decode methods in CharsetDecode.java. Although the original version
runs well, the structure of these two methods is messed. The refactored methods include:
> 1. public final CharBuffer decode(ByteBuffer in) throws CharacterCodingException;
> 2. public final CoderResult decode(ByteBuffer in, CharBuffer out,boolean endOfInput);
> Main changes:
> 1. remove embedded "while" in decode(ByteBuffer in, CharBuffer out,boolean endOfInput);
> 2. restruct condition control process in both two methods.
> 3. truncate return value of decode(in), which means the returned CharBuffer has the same
value between capacity and limit.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message