Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <613561179.1137655002798.JavaMail.jira@ajax.apache.org>
Date: Thu, 19 Jan 2006 08:16:42 +0100 (CET)
From: "Richard Liang (JIRA)" <jira@apache.org>
To: harmony-dev@incubator.apache.org
Subject: [jira] Commented: (HARMONY-32)
 java.text.Collator.setDecomposition(FULL_DECOMPOSITION)  throws
 IllegalArgumentException
In-Reply-To: <1392626750.1137477582492.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-32?page=comments#action_12363208 ] 

Richard Liang commented on HARMONY-32:
--------------------------------------

Having a looking at the javadoc of com.ibm.icu.text.Collator, I find that icu4j's collator officially supports only two decomposition mode: CANONICAL_DECOMPOSITION and NO_DECOMPOSITION. (FULL_DECOMPOSITION is in Deprecated status).

For this issue, throwing a more specific expcetion such as *NotYetImplementedException* may be a better solution.

Any comment?

Thanks a lot.

> java.text.Collator.setDecomposition(FULL_DECOMPOSITION)  throws IllegalArgumentException
> ----------------------------------------------------------------------------------------
>
>          Key: HARMONY-32
>          URL: http://issues.apache.org/jira/browse/HARMONY-32
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: tatyana doubtsova
>     Assignee: Geir Magnusson Jr

>
> Code for reproducing Test.java:
> import java.text.Collator;
> import java.util.Locale;
> public class Test {
> 	public static void main (String[] args) {
> 		Collator c = Collator.getInstance(Locale.US);
> 		c.setDecomposition(Collator.FULL_DECOMPOSITION);
> 		int decompositionMode = c.getDecomposition();
> 		System.out.println("decomposition Mode is " + decompositionMode);	 
> 	}
> }
> Steps to Reproduce:
> 1. Build Harmony-14 j2se subset as described in README.txt.
> 2. Compile Test.java using BEA 1.4 javac
> > javac -d . Test.java
> 2. Run java using compatible VM (J9)
> > java -showversion Test
>  
> Output:
> java version 1.4.2 (subset)
> (c) Copyright 1991, 2005 The Apache Software Foundation or its licensors, as applicable.
> Exception in thread "main" java.lang.IllegalArgumentException: Wrong decomposition mode.
> 	at com.ibm.icu.text.Collator.setDecomposition(Collator.java:295)
> 	at java.text.Collator.setDecomposition(Collator.java:277)
> 	at Test.main(Test.java:7)
> Output on BEA 1.4.2:
> decomposition Mode is 2
> Suggested junit test case:
> package org.apache.harmony.tests.java.text;
> import java.text.Collator;
> import java.util.Locale;
> import junit.framework.TestCase;
> public class CollatorTest extends TestCase {
> 	   public static void main(String[] args) {
> 	          junit.textui.TestRunner.run(CollatorTest.class);
> 	      }
> 	   
> 	   public void test_setDecomposition() {
> 		Collator c = Collator.getInstance(Locale.US);
> 		try {
> 			c.setDecomposition(Collator.FULL_DECOMPOSITION);			
> 		} catch (Exception e) {
> 			fail("Assert 0: Unexpected exception " + e);			
> 		}
> 		int decompositionMode = c.getDecomposition();
> 		assertTrue("Assert 1: next() returns incorrect value " + decompositionMode, decompositionMode == Collator.FULL_DECOMPOSITION );
> 	   }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira