Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: neutral (asf.osuosl.org: 217.158.94.220 is neither permitted nor
 denied by domain of t.p.ellison@gmail.com)
Message-ID: <43CE26FB.3090606@gmail.com>
Date: Wed, 18 Jan 2006 11:31:07 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: harmony-dev@incubator.apache.org
Subject: Re: problems with security2
References: <43CD2548.40608@pobox.com>
 <43CD73F8.3050107@pobox.com>	 <906dd82e0601172109k6229fc09yab25808db329de54@mail.gmail.com>
	 <906dd82e0601180012s509884b1kbdf87ede4c2832e7@mail.gmail.com>
	 <43CE1A07.3000503@gmail.com>
	 <906dd82e0601180256r58f54a52l4eddea2c92f1e1e4@mail.gmail.com>
 <6e47b64f0601180316k4be71120ob021a6de4e9cb71b@mail.gmail.com>
In-Reply-To: <6e47b64f0601180316k4be71120ob021a6de4e9cb71b@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Stepan Mishura wrote:
>> how would you distinguish between support classes for
>> java.security and javax.security?

Do we need to?  If they are in the same module then they are closely
coupled anyway -- the support classes could go into the same package.

>> we need org.apache.something
>> and org.apache.extension_of_something
> What about
> org.apache.harmony.security
> org.apache.harmonyx.security

Its an extension to security, not harmony, so I would have thought:
	org.apache.harmony.xsecurity

Regards,
Tim

> Thanks,
> Stepan
> On 1/18/06, Mikhail Loenko <mloenko@gmail.com> wrote:
>> On 1/18/06, Tim Ellison <t.p.ellison@gmail.com> wrote:
>>> Mikhail Loenko wrote:
>>>> Seems like I've managed to reproduce the problem:
>>>>
>>>> I've refactored the code using Eclipse: all that is under
>>>> com.openintel.drl.security
>>>> I've moved under
>>>> org.apache.harmony
>>> Can you make that org.apache.harmony.security -- then we keep the module
>>> name in there.  When we build into a single rt.jar it will avoid any
>>> unfortunate name collisions with implementations in other modules.
>> my misprint in the mail...
>>
>>>> Then I've searched for and found 18 files that still contained
>>>> "com.openintel.drl.security" for some reason, and made
>>>> search&replace
>>>>
>>>> After that build failed:
>>>> BUILD FAILED
>>>> build.xml:393: Test java.security.serialization.CodeSignerTest failed
>>>>
>>>> Will investigate...
>>>>
>>>>
>>>> BTW, where will we move "com.openintel.drlx" to?
>>>>
>>>> org.apache.harmony_x ?
>>>> org.apache.harmonx ?
>>>> org.apache.hx ?
>>> Yuk!  let's stick with org.apache.harmony.<whatever> package names.
>> how would you distinguish between support classes for
>> java.security and javax.security?
>>
>> we need org.apache.something
>> and org.apache.extension_of_something
>>
>> Thanks,
>> Mikhail
>>
>>
>>> Regards,
>>> Tim
>>>
>>>> Thanks,
>>>> Mikhail
>>>>
>>>>
>>>> On 1/18/06, Mikhail Loenko <mloenko@gmail.com> wrote:
>>>>> I've just updated from SVN, all unit tests from security2 passed
>>>>> (including serialization ones).
>>>>> Could you please provide more details?
>>>>>
>>>>> Thanks,
>>>>> Mikhail
>>>>>
>>>>>
>>>>> On 1/18/06, Geir Magnusson Jr <geir@pobox.com> wrote:
>>>>>> I am haplessly plodding along.  I found one problem (mine) which
>> fixed a
>>>>>> test, and now I seem to have a more interesting problem with the
>>>>>> serialization tests...
>>>>>>
>>>>>> Are the serialization tests "golden data" files somehow
>> dependent  the
>>>>>> com.openintel package structure and would be allergic to a
>>>>>> org.apache.harmony package structure?
>>>>>>
>>>>>> geir
>>>>>>
>>>>>>
>>>>>> Geir Magnusson Jr wrote:
>>>>>>> I've been trying to refactor security2 into the org.apache pacakage
>> space.
>>>>>>> I'm now having test failures.
>>>>>>>
>>>>>>> Can someone else do a co of security2 and verify?  I've backed out
>> the
>>>>>>> change so that you need junit and bcprov on your classpath (argh!)
>> and
>>>>>>> turned on haltonfailure so that the tests will stop once something
>> goes
>>>>>>> wrong.
>>>>>>>
>>>>>>> I thought I was being careful - while it's clear that I have no
>> idea
>>>>>>> what I'm doing, there's clearly something a little more subtle
>> going on
>>>>>>> here because I wouldn't think that just moving package names would
>> be a
>>>>>>> problem.  I assume that there's some provider or other
>> configuration-ish
>>>>>>> issue.
>>>>>>>
>>>>>>> This would be a good learning experience for all of us how this
>> works. I
>>>>>>> need to run out for about 20 min... bbiab.
>>>>>>>
>>>>>>> geir
>>>>>>>
>>>>>>>
>>> --
>>>
>>> Tim Ellison (t.p.ellison@gmail.com)
>>> IBM Java technology centre, UK.
>>>
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.