harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geir Magnusson Jr <g...@pobox.com>
Subject Re: [jira] Commented: (HARMONY-44) some security2 unit tests log redundant information
Date Thu, 26 Jan 2006 10:40:25 GMT
Sure - maybe start a new thread here?

Mikhail Loenko (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/HARMONY-44?page=comments#action_12364073 ]

> 
> Mikhail Loenko commented on HARMONY-44:
> ---------------------------------------
> 
> I've refactored a number of unit tests to get rid of 208 out of the 231 remaining "logln"s,

> so if someone applies the previous patch I'll submit the next one.
> 
> To complete it would be good to discuss how do we log when it is necessary
> 
> Thanks,
> Mikhail Loenko
> Intel Middleware Products Division
> 
> 
>> some security2 unit tests log redundant information
>> ---------------------------------------------------
>>
>>          Key: HARMONY-44
>>          URL: http://issues.apache.org/jira/browse/HARMONY-44
>>      Project: Harmony
>>         Type: Improvement
>>   Components: Classlib
>>     Reporter: Mikhail Loenko
>>     Assignee: Geir Magnusson Jr
>>     Priority: Trivial
>>  Attachments: patch.txt
>>
>> Information that is logged by security2 unit tests should be revisited. For example
the following logs at the beginning of tests 
>> are not necessary and should be removed:
>>         logln("==test_02: UnrecoverableKeyException==");
>> There are 231 occurrences of this kind out of 534 total logging calls in the security2
unit tests. I'm going to submit a patch
>> removing logln("==...
> 

Mime
View raw message