harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-26) The API of buffer classes in java.nio are not compliant with the specification of Java 5.0
Date Thu, 19 Jan 2006 10:44:44 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-26?page=comments#action_12363229 ] 

Tim Ellison commented on HARMONY-26:
------------------------------------

Gulp -- ok I'll start looking through this laundry list and fixing the NIO buffer code.

Do you have accompanying JUnit tests to go along with these defects?  Since you have contributor
paperwork on file I suggest you simply attach them to this issue (ensuring you mark them as
granting ASF license).

> The API of buffer classes in java.nio are not compliant with the specification of Java
5.0
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-26
>          URL: http://issues.apache.org/jira/browse/HARMONY-26
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Richard Liang
>     Assignee: Tim Ellison
>  Attachments: DirectBuffer.java
>
> 1. java.nio.CharBuffer
> 1.1) java.nio.CharBuffer needs to implement two new interface java.lang.Appendable and
java.lang.Readable
> 1.2) The following methods should NOT be "protected":
>     protected CharBuffer(int capacity)
> 	protected abstract char[] protectedArray();
> 	protected abstract int protectedArrayOffset();
> 	protected abstract boolean protectedHasArray();
> 	
> 1.3) The following method should be "final":
>     public CharBuffer put(char[] src)
>     
> 2. java.nio.Buffer
> 2.1) The following fields should NOT be "protected":
>     int UNSET_MARK
>     int capacity
>     int limit
>     int mark should
>     int position	
> 2.3) The following method should NOT be "protected":
>     protected Buffer(int capacity)
> 3. java.nio.ByteBuffer, DoubleBuffer, FloatBuffer, IntBuffer, LongBuffer, ShortBuffer
> 3.1) The following field should NOT be "protected":
>     com.ibm.platform.Endianness order
> 3.2) The following methods should NOT be "protected":
> 	protected ByteBuffer(int capacity)
> 	protected abstract byte[] protectedArray();
> 	protected abstract int protectedArrayOffset();
> 	protected abstract boolean protectedHasArray();
> 3.3) The following method should be "final":
>     public ByteBuffer order(ByteOrder byteOrder)
>     
> 4. The implementation of bulk put/get methods of all the buffer classes are low-efficiency
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message