Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of GHARLEY@uk.ibm.com designates
 195.212.29.136 as permitted sender)
In-Reply-To: <4391B1E3.60605@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Updated: (HARMONY-19) Divide by zero exception when
 rotating an
 empty List
MIME-Version: 1.0
From: George Harley1 <GHARLEY@uk.ibm.com>
Message-ID: 
 <OF0D2ED536.541CF464-ON802570CD.007B13A2-802570CD.007B4A5E@uk.ibm.com>
Date: Sun, 4 Dec 2005 22:26:33 +0000
Content-Type: text/plain; charset="US-ASCII"

Hi Tim, 

No worries. Tweak away.

Bye for now, 
George
________________________________________
George C. Harley


Tim Ellison <t.p.ellison@gmail.com> 
03/12/2005 14:55
Please respond to
harmony-dev@incubator.apache.org


To
harmony-dev@incubator.apache.org
cc

Subject
Re: [jira] Updated: (HARMONY-19) Divide by zero exception when rotating an 
empty List


George, I was just tweaking your JIRA report to reflect the new classlib
 component that Geir (I assume) created -- and it was something of an
experiment to see if JIRA allows people to modify other 'random' issues.

I've used Bugzilla before, but not JIRA so having a play, hope that's ok.

Regards,
Tim

Tim Ellison (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/HARMONY-19?page=all ]
> 
> Tim Ellison updated HARMONY-19:
> -------------------------------
> 
>     Component: Classlib
>                    (was: Contributions)
> 
> 
>>Divide by zero exception when rotating an empty List
>>----------------------------------------------------
>>
>>         Key: HARMONY-19
>>         URL: http://issues.apache.org/jira/browse/HARMONY-19
>>     Project: Harmony
>>        Type: Bug
>>  Components: Classlib
>> Environment: All
>>    Reporter: George Harley
>>    Assignee: Geir Magnusson Jr
>>    Priority: Minor
>> Attachments: HARMONY-19-patch-20051202.txt
>>
>>The implementation of method rotate(List, int) in java.util.Collections 
is not
>>checking the size of the input list prior to attempting the rotation. As 
a 
>>result, when called with an empty List argument a 
java.lang.ArithmeticException
>>will occur because of the the subsequent divide by zero operation. 
>>The problem can be demonstrated in the below unit test case ...
>>               public void testRotateEmptyList() {
>>                               // Create an *empty* list
>>                               List list = new ArrayList();
>>                               try {
>>                                               Collections.rotate(list, 
25);
>>                               } catch (Exception e) {
>>                                               fail("Unexpected 
exception rotating empty List : " + e);
>>                               }
>>               }
> 
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.