harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6620) [jdktools] Unit tests to test the functionality of the javac/javaw binaries
Date Wed, 13 Oct 2010 21:16:42 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920768#action_12920768
] 

Mark Hindess commented on HARMONY-6620:
---------------------------------------

It isn't ok.  I still don't understand the windows subdirectory without also having a "common"
subdirectory as is consistently the case with other modules.

I also noticed - though this wasn't made clear in your submissions - that you seem to have
just copied and pasted code (twice) from Support_Exec.java and modified it.  It clearly makes
more sense to make a helper class that can be use in both places (and hopefully more - since
we obviously need to test other tools as well) rather than maintaining three copies of not
quite identical code.

As it turns out the instrument module has a Runtime.Exec helper too so I am hopeful we can
combine these to come up with a combined support class.  I will take a look at this.



> [jdktools] Unit tests to test the functionality of the javac/javaw binaries
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-6620
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6620
>             Project: Harmony
>          Issue Type: Test
>          Components: JDK
>         Environment: Windows and Linux
>            Reporter: Prashanth KS
>         Attachments: 001_HARMONY_6620.patch, 002_HARMONY_6620.patch, 003_HARMONY_6620.patch,
004_HARMONY_6620.patch, resources.zip, TEST-org.apache.harmony.tests.tools.javac.binary.JavacBinTest.xml
>
>
> The ANT unit tests written for the jdktools binaries such as javac aren't flexible enough.
i.e. if there is a test failure then the rest of the tests are skipped. Moreover, there aren't
a lot of test scenarios created for these binaries.
> Added Unit tests to test the javac.exe and javaw.exe tools. This helps in providing a
better analysis of these tools across different runtimes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message