Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 78088 invoked from network); 22 Sep 2010 01:33:57 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Sep 2010 01:33:57 -0000 Received: (qmail 36948 invoked by uid 500); 22 Sep 2010 01:33:57 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 36924 invoked by uid 500); 22 Sep 2010 01:33:56 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 36917 invoked by uid 99); 22 Sep 2010 01:33:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Sep 2010 01:33:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Sep 2010 01:33:54 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8M1XWqq027799 for ; Wed, 22 Sep 2010 01:33:33 GMT Message-ID: <3263140.332511285119212977.JavaMail.jira@thor> Date: Tue, 21 Sep 2010 21:33:32 -0400 (EDT) From: "Robert Muir (JIRA)" To: commits@harmony.apache.org Subject: [jira] Closed: (HARMONY-6649) String.toLowerCase/toUpperCase incorrect for supplementary characters In-Reply-To: <16069276.187651284495167890.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir closed HARMONY-6649. -------------------------------- I tested this, additionally the lucene test case that was failing now passes. in fact: all of core lucene now passes with harmony! as for the equalsIgnoreCase, i looked at the javadocs to see what the behavior should be. According to the javadocs, it seems the existing harmony behavior is correct, because they explicitly say that equalsIgnoreCase should use toLowerCase(char) and toUpperCase(char) > String.toLowerCase/toUpperCase incorrect for supplementary characters > --------------------------------------------------------------------- > > Key: HARMONY-6649 > URL: https://issues.apache.org/jira/browse/HARMONY-6649 > Project: Harmony > Issue Type: Bug > Components: Classlib > Affects Versions: 5.0M15 > Reporter: Robert Muir > Assignee: Tim Ellison > Fix For: 5.0M15 > > Attachments: HARMONY-6649_tests.patch, harmony6649.patch > > > Simple testcase: > {code} > assertEquals("\uD801\uDC44", "\uD801\uDC1C".toLowerCase()); > {code} > Looking at modules/luni/src/main/java/java/lang/String.java, the problem is these methods iterate code units (char) not codepoints (int), > and use Character.toLowerCase(char) and Character.toUpperCase(char), instead of Character.toLowerCase(int), and Character.toUpperCase(int) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.