Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 1259 invoked from network); 30 Sep 2010 21:35:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Sep 2010 21:35:05 -0000 Received: (qmail 48676 invoked by uid 500); 30 Sep 2010 21:35:05 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 48654 invoked by uid 500); 30 Sep 2010 21:35:05 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 48647 invoked by uid 99); 30 Sep 2010 21:35:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Sep 2010 21:35:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Sep 2010 21:35:02 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8ULYfH7004406 for ; Thu, 30 Sep 2010 21:34:41 GMT Message-ID: <19288834.486651285882481345.JavaMail.jira@thor> Date: Thu, 30 Sep 2010 17:34:41 -0400 (EDT) From: "Hudson (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-6638) [classlib][nio]Some Selector behavior fixed. In-Reply-To: <18182878.87561283237333284.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916685#action_12916685 ] Hudson commented on HARMONY-6638: --------------------------------- Integrated in Harmony-select-1.5-head-linux-x86_64 #126 (See [https://hudson.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/126/]) Applying patch from HARMONY-6638: 1. In Linux, ServerSocketChannel should be acceptable if its server socket bind any address. 2. In Linux, SocketChannel should be connectable if it does not connect anything. 3. The Selector should also return if an error occurred. 4. If user change the interested operations of a selector, this selector should treated as a new one (but with the same SelectionKey). On the other hand, if the selector was return once and no interested operation changed, it should not be selected next time. > [classlib][nio]Some Selector behavior fixed. > -------------------------------------------- > > Key: HARMONY-6638 > URL: https://issues.apache.org/jira/browse/HARMONY-6638 > Project: Harmony > Issue Type: Bug > Components: Classlib > Affects Versions: 5.0M14 > Reporter: Li Jing Qin > Assignee: Li Jing Qin > Priority: Critical > Attachments: HARMONY-6638.diff > > > There are some problems with harmony Selector: > 1. When a serversocket channel does not bind anything, selector should return acceptable. In this situation, poll return POLLHUP. I add this flag to the native code. > 2. The same as 1, when a socketChannel does not connect any anything, selector should return connectable. In this situation, poll return POLLHUP, I also add this flag to the native code. > 3. As the spec said, selector should also return if an error occurred. I'm not testing the error condition, but I add POLLERR to the native code. > 4. If user change the interested operations of a selector, this selector should treated as a new one (but with the same SelectionKey). On the other hand, if the selector was return once and no interested operation changed, it should not be selected next time. I have add a flag stateChange in the SelectionKeyImpl to save this state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.