harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6627) [classlib][x-net] Creating a JSSE provider based on OpenSSL
Date Mon, 13 Sep 2010 21:02:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908996#action_12908996

Oliver Deakin commented on HARMONY-6627:

Thanks for the new patch. I haven't applied it yet as I have a couple of comments:
 - The calls into the SSLParameters class (e.g. setEnabledParameters() ) are broken by this
change as they expect to be passed an SSL pointer and are now being passed a pointer to the
struct used in the SSLEngine natives. I think the SSLEngine class will need to store the SSL*
as well as the pointer to the struct containing the two bios. It will also mean you don't
need to call BIO_get_ssl() in all of the native functions, just pass in the SSL pointer instead.
 - I think the instance variable name "SSLEngine" is confusing. It is the name of the superclass
of SSLEngineImpl and also the parameter name sslEngineAddress is used in all the native method
signatures. sslEngineAddress is a better name IMO.

What are your thoughts on these?

> [classlib][x-net] Creating a JSSE provider based on OpenSSL
> -----------------------------------------------------------
>                 Key: HARMONY-6627
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6627
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Catherine Hope
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: x-net-2.patch, x-net-3.patch, x-net-4.patch, x-net-5.patch, x-net.patch
> Umbrella JIRA to attach patches to https://svn.apache.org/repos/asf/harmony/enhanced/java/branches/omd
for work on implementing a JSSE provider using OpenSSL

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message