harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6627) [classlib][x-net] Creating a JSSE provider based on OpenSSL
Date Fri, 20 Aug 2010 19:47:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900838#action_12900838

Oliver Deakin commented on HARMONY-6627:

Thanks Cath - x-net-2.patch applied at repo revision r987613, but I had to make some modifications:
 - ioctl() does not exist on Windows (or ioctl.h) so this broke the build. I changed the code
to implement available() in the same way SocketInputStream and PlainSocketImpl do, using the
INetworkSystem.availableStream(fd) interface to get the available bytes. This saves us reimplementing
these natives in x-net.
 - just a minor change, but some of the indentation was made up of mixed tabs and spaces -
you may want to check the settings you have to make sure they use spaces.

Please check that this patch (and the first one) applied as expected and that you're happy
with the modifications I made.

> [classlib][x-net] Creating a JSSE provider based on OpenSSL
> -----------------------------------------------------------
>                 Key: HARMONY-6627
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6627
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Catherine Hope
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: x-net-2.patch, x-net.patch
> Umbrella JIRA to attach patches to https://svn.apache.org/repos/asf/harmony/enhanced/java/branches/omd
for work on implementing a JSSE provider using OpenSSL

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message