harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6621) [classlib][nio] Minor testcase improvements to ServerSocketChannelTest and SocketChannelTest
Date Fri, 13 Aug 2010 09:27:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898146#action_12898146
] 

Oliver Deakin commented on HARMONY-6621:
----------------------------------------

Before applying the patch both SocketChannelTest and ServerSocketChannelTest passed on Windows
x86. After applying the patch SocketChannelTest.testCFII_StatusAfterFinish() fails with:

Expected ConnectException
junit.framework.AssertionFailedError: Expected ConnectException
at org.apache.harmony.nio.tests.java.nio.channels.SocketChannelTest.testCFII_StatusAfterFinish(SocketChannelTest.java:1385)
at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)

It looks like the new expectation added to this test that a ConnectException will be thrown
does not apply across platforms.

ServerSocketChannelTest passed ok after the patch was applied, so I have committed this change
at repo revision r985141. Please check it was applied as expected.

> [classlib][nio] Minor testcase improvements to ServerSocketChannelTest and SocketChannelTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6621
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6621
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Catherine Hope
>            Priority: Minor
>         Attachments: nio.patch
>
>
> ServerSocketChannelTest will hang in 4 tests when run on platforms that have small socket
buffers, such as z/OS.  The tests are trying to send large amounts of data, so if the read
or write cannot complete before the corresponding write or read takes place then the I/O will
block from returning.  I think this can only be fixed by having using threads in the testcase.
> Minor change to SocketChannelTest.testCFII_StatusAfterFinish to remove output to stderr
and fail if the expected exception wasn't thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message