Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 21601 invoked from network); 9 Jul 2010 05:32:48 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Jul 2010 05:32:48 -0000 Received: (qmail 98879 invoked by uid 500); 9 Jul 2010 05:32:47 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 98781 invoked by uid 500); 9 Jul 2010 05:32:45 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 98773 invoked by uid 99); 9 Jul 2010 05:32:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jul 2010 05:32:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jul 2010 05:32:41 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o695Onkc028899 for ; Fri, 9 Jul 2010 05:24:50 GMT Message-ID: <9774219.278491278653089753.JavaMail.jira@thor> Date: Fri, 9 Jul 2010 01:24:49 -0400 (EDT) From: "Regis Xu (JIRA)" To: commits@harmony.apache.org Subject: [jira] Closed: (HARMONY-6052) [classlib][luni] remove platform specific code in socket.c::pollSelectRead In-Reply-To: <1436098416.1229503124316.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Regis Xu closed HARMONY-6052. ----------------------------- Fix Version/s: (was: 5.0M9) Resolution: Fixed pollSelectRead has already moved to platform folders in latest code repository. > [classlib][luni] remove platform specific code in socket.c::pollSelectRead > -------------------------------------------------------------------------- > > Key: HARMONY-6052 > URL: https://issues.apache.org/jira/browse/HARMONY-6052 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Affects Versions: 5.0M8 > Reporter: Regis Xu > Attachments: HARMONY-6052.diff > > > in socket.c::pollSelectRead, there are some codes like: > #if defined(WIN32) > .... > #else > .... > #endif > It seems hysock_select_read has different behaviors between Windows and Linux, (maybe return value means different things?) > I think these platform specific codes could be move to portlib and make socket.c more clear. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.