harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deven you (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6594) [classlib][nio_cahr] CharsetEncoder.flush(Bytebuffer) doesn't follow the spec and RI's behavior
Date Fri, 23 Jul 2010 05:49:49 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891476#action_12891476
] 

deven you commented on HARMONY-6594:
------------------------------------

I have put the updated version HARMONY-6594_v2.diff, it can fix our flush() behavior so that
our flush() will completely follows RI5's behavior. The basic concept of this fix is that
dividing the INIT state into 2 states INIT and READY, the former indicates the encoder just
is initiated and won't accept the flush() operation, the latter indicates the encoder is ready
to accept the flush() operation,  and following RI5's behavior set the state as INIT after
calling the constructor and reset() methods. This simple concept will comply with RI5 and
won't cause it complex to understand.
Anyone want to test this fix? Thanks a lot!

> [classlib][nio_cahr] CharsetEncoder.flush(Bytebuffer) doesn't  follow the spec and RI's
behavior
> ------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6594
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6594
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M14
>            Reporter: deven you
>         Attachments: HARMONY-6594.diff, HARMONY-6594_v2.diff
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Java 5 spec says the fulsh() will throw IllegalStateException  If the previous step of
the current encoding operation was an invocation neither of the reset method nor of the three-argument
encode method with a value of true for the endOfInput parameter.
> Our harmony one doesn't follow this behavior and won't throw Exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message