Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 22877 invoked from network); 22 Apr 2010 10:44:07 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Apr 2010 10:44:07 -0000 Received: (qmail 11400 invoked by uid 500); 22 Apr 2010 10:44:07 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 11295 invoked by uid 500); 22 Apr 2010 10:44:05 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 11288 invoked by uid 99); 22 Apr 2010 10:44:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Apr 2010 10:44:05 +0000 X-ASF-Spam-Status: No, hits=-1474.4 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Apr 2010 10:44:04 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 7659723889B8; Thu, 22 Apr 2010 10:43:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r936766 - /harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c Date: Thu, 22 Apr 2010 10:43:22 -0000 To: commits@harmony.apache.org From: odeakin@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100422104322.7659723889B8@eris.apache.org> Author: odeakin Date: Thu Apr 22 10:43:22 2010 New Revision: 936766 URL: http://svn.apache.org/viewvc?rev=936766&view=rev Log: Remove error printf() - loadImpl is only called (indirectly) from MappedByteBuffer.load(). Since that method is a "best effort" to load into physical memory, we should not print an error when that load fails. Just return an error value (this matches the behaviour on Unix). Modified: harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c Modified: harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c URL: http://svn.apache.org/viewvc/harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c?rev=936766&r1=936765&r2=936766&view=diff ============================================================================== --- harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c (original) +++ harmony/enhanced/java/trunk/classlib/modules/luni/src/main/native/luni/windows/OSMemoryWin32.c Thu Apr 22 10:43:22 2010 @@ -80,7 +80,6 @@ JNIEXPORT jint JNICALL Java_org_apache_h VirtualUnlock((void *)addr, (SIZE_T)size); return 0; }else{ - printf("lock error: %d\n", GetLastError()); return -1; } }