Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1154645968.260411268634927420.JavaMail.jira@brutus.apache.org>
Date: Mon, 15 Mar 2010 06:35:27 +0000 (UTC)
From: "Li Jing Qin (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-6465) [classlib][nio]Small fixes
 according to the findbug results
In-Reply-To: <1826012892.199491268297907242.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845200#action_12845200 ] 

Li Jing Qin commented on HARMONY-6465:
--------------------------------------

I have refresh my code base. It seems the point 2 I have removed has already been excluded. (sigh)

> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
>                 Key: HARMONY-6465
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6465
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>            Priority: Minor
>             Fix For: 5.0M14
>
>         Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.